Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC changes for protocol Q (part 2) #3023

Closed
dsawali opened this issue Aug 15, 2024 · 4 comments
Closed

RPC changes for protocol Q (part 2) #3023

dsawali opened this issue Aug 15, 2024 · 4 comments
Assignees
@hui-an-yang
Labels
quebec rpc
Milestone
v21

Comments

@dsawali
Copy link
Contributor

dsawali commented Aug 15, 2024

In the 2 following paths ../ is short for /chains/<chain_id>/blocks/<block_id>/context/contracts/<contract_id>/

  • Added RPC GET ../spendable which is identical to GET ../balance
  • Added RPC GET ../spendable_and_frozen_bonds which is identical to GET ../balance_and_frozen_bonds
@dsawali dsawali changed the title [RPC] RPC changes for Quebec (part 2) [RPC] RPC changes for protocol Q (part 2) Aug 15, 2024
@dsawali dsawali changed the title [RPC] RPC changes for protocol Q (part 2) RPC changes for protocol Q (part 2) Aug 15, 2024
@dsawali dsawali added this to the v21 milestone Sep 5, 2024
@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Sep 5, 2024 •
edited
Loading

Are we adding new endpoint in rpc accordingly?
like getSpendable and getSpendableAndFrozenBonds to our RpcClient?

hui-an-yang added a commit that referenced this issue Sep 9, 2024
@hui-an-yang
feat: add getSpendable rpc endpoint
1cd66b4 
re #3023
hui-an-yang added a commit that referenced this issue Sep 9, 2024
@hui-an-yang
feat: add getBalanceAndFrozenBonds and getSpendableAndFrozenBonds rpc…
750fe59 
… endpoint

re #3023
@hui-an-yang hui-an-yang mentioned this issue Sep 9, 2024
Closed
9 tasks
@dsawali
Copy link
Contributor Author

dsawali commented Sep 9, 2024

in the beginning I thought it would be good to add them, but since we aren't really supporting the other endpoints for bakers, this change seems like it doesn't need to happen. I'll be closing it

@dsawali dsawali closed this as completed Sep 9, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Taquito Dev Sep 9, 2024
@hui-an-yang
Copy link
Collaborator

This one actually related to our user it's based of contracts/<contract_id>/ and we do support contracts/<contract_id>/balance seem to make sense to support contracts/<contract_id>/spendable
And
And a good idea to support ../spendable_and_frozen_bonds and ../balance_and_frozen_bonds too

@hui-an-yang hui-an-yang reopened this Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Taquito Dev Sep 13, 2024
@hui-an-yang hui-an-yang moved this from Review approved to Review in progress in Taquito Dev Sep 27, 2024
@hui-an-yang hui-an-yang self-assigned this Oct 2, 2024
@hui-an-yang hui-an-yang linked a pull request Oct 2, 2024 that will close this issue
Betanet0829 #3040
Closed
9 tasks
hui-an-yang added a commit that referenced this issue Jan 7, 2025
@hui-an-yang
Quebec (#3068)
fa8b6f0 
* add betanet0829 protocol hash and chainID

* test: configured integration test run on betanet0829

* test: update integration-test files for betanet

* ci: update betanet script name

* feat: add ConstantsResponseProto021 to ConstantsResponse

fix #3037

* feat: removed endorsement compatiblity but kept rpc types and readProvider for user query old block

BREAKING CHANGE: PollingSubscribeProvider doesn't filter endorsement anymore and removed rpc
entrypoints using param version  0

re #3036

* feat: getPendingOperations add param source and operationHash and removed type PendingOperationsV1

BREAKING CHANGE: PendingOperationsQueryArguments.version used to accept 1 is removed for protocol q

re #3034

* test: update estimation-tests assertion

* test: improve failing-noop and staking tests

* feat: add getSpendable rpc endpoint

re #3023

* feat: add getBalanceAndFrozenBonds and getSpendableAndFrozenBonds rpc endpoint

re #3023

* docs: update rpc nodes doc

* test: update estimation-tests assertion

* test: update estimation-tests assertion

* ci: updated ci script with rpc_url

* test: updated testing for weeklynet

* feat: configured quebec protocol and chainId

* test: configured quebec integration tests and ci runs

* docs: updated places with quebec

* test: improved staking tests

* test: imporved staking tests

* test: configured to run tests on new quebec testnet

* feat: updated quebec new chainId

* chore: fixed dependency vulnerabilities

* test: correct ghostnet protocol config

* test: updated estimation assertions

* test: updated private rpc url for ci

* test: adjusted estimation assertions, improve staking test and test config for beta release

* docs: updated rpc nodes urls

* chore(releng) bump version to 21.0.0-beta.1

* ci: update quebecnet rpc urls

* fix: adding PendingOperationsV1 support to smooth migration from paris to quebec on mainnet

* test: updated quebecnet and weeklynet rpc url

* test: updated estimate assertions

* feat: updated beacon to 4.3.2-beta.0 and enable test-dapp with quebecnet

* chore(releng) bump version to 21.0.0-RC.0

* chore: updated dependencies suggested by snyk

* test: updated test assertion and improvet nodes.spec also fix live code example bugs

* ci: updated ci to run bundle_webpack.yml workflow every pr

* chore(releng) bump version to 21.0.0

* docs: updated website versioned_docs to be latest 5 versions
@hui-an-yang
Copy link
Collaborator

merged in master by #3068 therefore closing this

@github-project-automation github-project-automation bot moved this from Review in progress to Done in Taquito Dev Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
quebec rpc
Projects
Taquito Dev
Status: Done
Milestone
v21
Development

Successfully merging a pull request may close this issue.

Betanet0829 ecadlabs/taquito
2 participants
@dsawali @hui-an-yang