From a8cc87d4b83fbb2ef0ac4ae1c8d8a8b9b1b4b5dc Mon Sep 17 00:00:00 2001 From: Eugene Bekker Date: Thu, 26 Oct 2017 15:19:41 -0400 Subject: [PATCH 1/4] Relocating DNS-Made-Easy provider to its own project * As per the new structure, Providers are now isolated to their own project and distributed separate from the main ACMESharp core library. * Also updated to work with the updated interface definition for Challenge Handlers --- .../ACMESharp.Providers.DNSMadeEasy.csproj | 62 ++++++++++ .../ACMESharp.Providers.DNSMadeEasy.nuspec | 23 ++++ .../ACMESharp.Providers.DNSMadeEasy.psd1 | 112 ++++++++++++++++++ .../DnsMadeEasyChallengeHandler.cs | 35 +++--- .../DnsMadeEasyChallengeHandlerProvider.cs | 13 +- .../Properties/AssemblyInfo.cs | 23 ++++ .../packages.config | 4 + ACMESharp/ACMESharp.sln | 11 +- ACMESharp/ACMESharp/ACMESharp.csproj | 2 - 9 files changed, 259 insertions(+), 26 deletions(-) create mode 100644 ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj create mode 100644 ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec create mode 100644 ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 rename ACMESharp/{ACMESharp/ACME/Providers => ACMESharp.Providers.DNSMadeEasy}/DnsMadeEasyChallengeHandler.cs (93%) rename ACMESharp/{ACMESharp/ACME/Providers => ACMESharp.Providers.DNSMadeEasy}/DnsMadeEasyChallengeHandlerProvider.cs (92%) create mode 100644 ACMESharp/ACMESharp.Providers.DNSMadeEasy/Properties/AssemblyInfo.cs create mode 100644 ACMESharp/ACMESharp.Providers.DNSMadeEasy/packages.config diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj new file mode 100644 index 00000000..cc89965c --- /dev/null +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj @@ -0,0 +1,62 @@ + + + + + Debug + AnyCPU + {BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A} + Library + Properties + ACMESharp.Providers.DNSMadeEasy + ACMESharp.Providers.DNSMadeEasy + v4.6.1 + 512 + + + true + full + false + bin\Debug\ + DEBUG;TRACE + prompt + 4 + + + pdbonly + true + bin\Release\ + TRACE + prompt + 4 + + + + ..\packages\Newtonsoft.Json.9.0.1\lib\net45\Newtonsoft.Json.dll + + + + + + + + + + + + + + + + + + + + {d551234b-0a8d-4dee-8178-a81998df0edb} + ACMESharp + + + + + + + \ No newline at end of file diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec new file mode 100644 index 00000000..b1fedfd8 --- /dev/null +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec @@ -0,0 +1,23 @@ + + + + + $id$ + $version$.$buildNum$$versionLabel$ + $title$ + https://github.com/ebekker + https://github.com/ebekker + https://raw.githubusercontent.com/ebekker/ACMESharp/master/LICENSE + https://github.com/ebekker/ACMESharp + https://cdn.rawgit.com/ebekker/ACMESharp/49bf6524da8239ecf258ab3857dfbbf40366ecfd/artwork/ACMESharp-logo-square64.png + false + $description$ + Early-access release of ACMESharp Provider Lib for CloudFlare. + Copyright © 2017 Eugene Bekker + pki ssl tls security certificates letsencrypt acme acmesharp + + + + + + diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 new file mode 100644 index 00000000..7c748172 --- /dev/null +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 @@ -0,0 +1,112 @@ + +## For a reference of this file's elements, see: +## https://technet.microsoft.com/library/hh849709.aspx +## https://technet.microsoft.com/en-us/library/dd878297(v=vs.85).aspx + +## 64-bit: +## %SystemRoot%\system32\WindowsPowerShell\v1.0\powershell.exe +## 32-bit: +## %SystemRoot%\syswow64\WindowsPowerShell\v1.0\powershell.exe + +@{ + ## This is a manifest-only module so we don't define any root + #RootModule = '' + + ModuleVersion = '0.8.5' + GUID = '7F6533CB-B35A-4E08-BD31-7561D0CC2A7B' + + Author = 'https://github.com/ebekker' + + CompanyName = 'https://github.com/ebekker/ACMESharp' + + Copyright = '(c) 2016 Jan-Pieter Zoutewelle. All rights reserved.' + + Description = "CloudFlare Provider extension library for ACMESharp Client." + + # Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix. + DefaultCommandPrefix = 'ACME' + + ## Minimum version of the Windows PowerShell engine required by this module + ## This does not appear to be enforce for versions > 2.0 as per + ## https://technet.microsoft.com/en-us/library/dd878297(v=vs.85).aspx + PowerShellVersion = '3.0' + + DotNetFrameworkVersion = '4.5' + + # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell. + PrivateData = @{ + + PSData = @{ + + # Tags applied to this module. These help with module discovery in online galleries. + Tags = @('pki','ssl','tls','security','certificates','letsencrypt','acme','powershell','acmesharp','cloudflare','acmesharp_ext') + + # A URL to the license for this module. + LicenseUri = 'https://raw.githubusercontent.com/ebekker/ACMESharp/master/LICENSE' + + # A URL to the main website for this project. + ProjectUri = 'https://github.com/ebekker/ACMESharp' + + # A URL to an icon representing this module. + IconUri = 'https://cdn.rawgit.com/ebekker/ACMESharp/master/artwork/ACMESharp-logo-square64.png' + + # ReleaseNotes of this module + ReleaseNotes = 'Please see the release notes from the release distribution page: https://github.com/ebekker/ACMESharp/releases' + + } # End of PSData hashtable + + } # End of PrivateData hashtable + + # Modules that must be imported into the global environment prior to importing this module + RequiredModules = @( ## FYI -- If one module uses the Hashtable spec, they all have to + + ## The minimum version of ACMESharp that supports our form of a Provider + ## extension as a dynamically installed and *enabled* POSH Extension Module + , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + ) + + + ############################################################ + ## Unused manifest elements reserved for possible future use + ############################################################ + + # HelpInfo URI of this module for updateable help + # HelpInfoURI = '' + + # Assemblies that must be loaded prior to importing this module + # RequiredAssemblies = @() + + # Script files (.ps1) that are run in the caller's environment prior to importing this module. + # ScriptsToProcess = @() + + # Type files (.ps1xml) to be loaded when importing this module + # TypesToProcess = @() + + # Format files (.ps1xml) to be loaded when importing this module + # FormatsToProcess = @() + + # Modules to import as nested modules of the module specified in RootModule/ModuleToProcess + # NestedModules = @() + + # Functions to export from this module + # FunctionsToExport = '*' + + # Cmdlets to export from this module + # CmdletsToExport = '*' + + # Variables to export from this module + # VariablesToExport = '*' + + # Aliases to export from this module + # AliasesToExport = '*' + + # DSC resources to export from this module + # DscResourcesToExport = @() + + # List of all modules packaged with this module + # ModuleList = @() + + # List of all files packaged with this module + # FileList = @() + +} diff --git a/ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandler.cs b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandler.cs similarity index 93% rename from ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandler.cs rename to ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandler.cs index 7a069850..68ad518d 100644 --- a/ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandler.cs +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandler.cs @@ -1,17 +1,15 @@ -using System; -using System.Collections.Generic; +using ACMESharp.ACME; +using Newtonsoft.Json; +using System; +using System.IO; using System.Linq; -using System.Text; -using System.Threading.Tasks; -using System.Management; -using System.Security.Cryptography; using System.Net; -using System.IO; -using Newtonsoft.Json; +using System.Security.Cryptography; +using System.Text; -namespace ACMESharp.ACME.Providers +namespace ACMESharp.Providers.DNSMadeEasy { - public class DnsMadeEasyChallengeHandler : IChallengeHandler + public class DnsMadeEasyChallengeHandler : IChallengeHandler { public string ApiKey { get; set; } public string SecretKey { get; set; } @@ -22,9 +20,9 @@ public bool IsDisposed get; private set; } - public void CleanUp(Challenge c) + public void CleanUp(ChallengeHandlingContext ctx) { - var dnsChallenge = (DnsChallenge)c; + var dnsChallenge = (DnsChallenge)ctx.Challenge; var domainDetails = GetDomainId(dnsChallenge); var records = managedPath + domainDetails.DomainId + "/records"; @@ -66,7 +64,13 @@ private string GetRecordId(DnsChallenge dnsChallenge, DomainDetails domainDetail return null; } - public void Dispose() + private void AssertNotDisposed() + { + if (IsDisposed) + throw new InvalidOperationException("handler is disposed"); + } + + public void Dispose() { IsDisposed = true; } @@ -74,9 +78,10 @@ public void Dispose() private readonly string managedPath = "dns/managed/"; private readonly string nameQuery = "name?domainname="; - public void Handle(Challenge c) + public void Handle(ChallengeHandlingContext ctx) { - var dnsChallenge = (DnsChallenge)c; + AssertNotDisposed(); + var dnsChallenge = (DnsChallenge)ctx.Challenge; var domainDetails = GetDomainId(dnsChallenge); var records = managedPath + domainDetails.DomainId + "/records"; diff --git a/ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandlerProvider.cs b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandlerProvider.cs similarity index 92% rename from ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandlerProvider.cs rename to ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandlerProvider.cs index 2a0acc75..47e98f21 100644 --- a/ACMESharp/ACMESharp/ACME/Providers/DnsMadeEasyChallengeHandlerProvider.cs +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/DnsMadeEasyChallengeHandlerProvider.cs @@ -1,19 +1,16 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; +using ACMESharp.ACME; using ACMESharp.Ext; +using System.Collections.Generic; -namespace ACMESharp.ACME.Providers +namespace ACMESharp.Providers.DNSMadeEasy { /// /// Provider for a Challenge Handler that updates the TXT records on a - /// DNS Made Easy account. + /// DNS Made Easy account. /// /// /// The staging environment is available as an option, but Let's Encrypt - /// won't be able to read these values, so this is for debugging only + /// won't be able to read these values, so this is for debugging only /// [ChallengeHandlerProvider("dnsme", ChallengeTypeKind.DNS, diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/Properties/AssemblyInfo.cs b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/Properties/AssemblyInfo.cs new file mode 100644 index 00000000..505a0f3e --- /dev/null +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/Properties/AssemblyInfo.cs @@ -0,0 +1,23 @@ +using System.Reflection; +using System.Runtime.CompilerServices; +using System.Runtime.InteropServices; + +// General Information about an assembly is controlled through the following +// set of attributes. Change these attribute values to modify the information +// associated with an assembly. +[assembly: AssemblyTitle("ACMESharp DNS-Made-Easy Provider")] +[assembly: AssemblyDescription("DNS-Made-Easy Provider extension for ACMESharp")] +[assembly: AssemblyConfiguration("")] +[assembly: AssemblyCompany("github.com/ebekker/ACMESharp")] +[assembly: AssemblyProduct("ACMESharp.Providers.DNSMadeEasy")] +[assembly: AssemblyCopyright("Copyright © 2017 Matthew Steeples. All rights reserved.")] +[assembly: AssemblyTrademark("")] +[assembly: AssemblyCulture("")] + +// Setting ComVisible to false makes the types in this assembly not visible +// to COM components. If you need to access a type in this assembly from +// COM, set the ComVisible attribute to true on that type. +[assembly: ComVisible(false)] + +// The following GUID is for the ID of the typelib if this project is exposed to COM +[assembly: Guid("bc6d303a-71fb-4cc7-8d30-3c3b09f9c92a")] diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/packages.config b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/packages.config new file mode 100644 index 00000000..7ee8c105 --- /dev/null +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/packages.config @@ -0,0 +1,4 @@ + + + + \ No newline at end of file diff --git a/ACMESharp/ACMESharp.sln b/ACMESharp/ACMESharp.sln index 4ba2e83c..c9a25e28 100644 --- a/ACMESharp/ACMESharp.sln +++ b/ACMESharp/ACMESharp.sln @@ -1,7 +1,7 @@  Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 15 -VisualStudioVersion = 15.0.26430.14 +VisualStudioVersion = 15.0.26730.3 MinimumVisualStudioVersion = 10.0.40219.1 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ACMESharp", "ACMESharp\ACMESharp.csproj", "{D551234B-0A8D-4DEE-8178-A81998DF0EDB}" EndProject @@ -75,6 +75,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ACMESharp.Providers.Windows EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ACMESharp.PKI.Providers.OpenSslLib", "ACMESharp.PKI.Providers.OpenSslLib\ACMESharp.PKI.Providers.OpenSslLib.csproj", "{86961A92-474A-4C0C-9A7D-F6EDD57EFD56}" EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ACMESharp.Providers.DNSMadeEasy", "ACMESharp.Providers.DNSMadeEasy\ACMESharp.Providers.DNSMadeEasy.csproj", "{BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU @@ -149,6 +151,10 @@ Global {86961A92-474A-4C0C-9A7D-F6EDD57EFD56}.Debug|Any CPU.Build.0 = Debug|Any CPU {86961A92-474A-4C0C-9A7D-F6EDD57EFD56}.Release|Any CPU.ActiveCfg = Release|Any CPU {86961A92-474A-4C0C-9A7D-F6EDD57EFD56}.Release|Any CPU.Build.0 = Release|Any CPU + {BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A}.Debug|Any CPU.Build.0 = Debug|Any CPU + {BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A}.Release|Any CPU.ActiveCfg = Release|Any CPU + {BC6D303A-71FB-4CC7-8D30-3C3B09F9C92A}.Release|Any CPU.Build.0 = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE @@ -158,4 +164,7 @@ Global {4F61BC69-0B98-45E1-87C1-D2BCF0352E06} = {A6084888-8C82-4999-880F-2721BF1AA639} {34013351-8A64-4272-AFF0-2ADE706E5019} = {A6084888-8C82-4999-880F-2721BF1AA639} EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {2956BBB7-4342-48B8-9005-03A31A313B8D} + EndGlobalSection EndGlobal diff --git a/ACMESharp/ACMESharp/ACMESharp.csproj b/ACMESharp/ACMESharp/ACMESharp.csproj index f217e30a..663708d5 100644 --- a/ACMESharp/ACMESharp/ACMESharp.csproj +++ b/ACMESharp/ACMESharp/ACMESharp.csproj @@ -94,8 +94,6 @@ - - From 444b57fe69861bc613f9462d193bdc6ac3cf6cf6 Mon Sep 17 00:00:00 2001 From: Eugene Bekker Date: Thu, 26 Oct 2017 15:25:34 -0400 Subject: [PATCH 2/4] Fixing up NuGet and PS Module packaging --- .../ACMESharp.Providers.DNSMadeEasy.nuspec | 6 +++--- .../ACMESharp.Providers.DNSMadeEasy.psd1 | 12 ++++++------ ci/av-build.ps1 | 10 ++++++---- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec index b1fedfd8..6def536f 100644 --- a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.nuspec @@ -12,12 +12,12 @@ https://cdn.rawgit.com/ebekker/ACMESharp/49bf6524da8239ecf258ab3857dfbbf40366ecfd/artwork/ACMESharp-logo-square64.png false $description$ - Early-access release of ACMESharp Provider Lib for CloudFlare. + Early-access release of ACMESharp Provider Lib for DNS Made Easy. Copyright © 2017 Eugene Bekker - pki ssl tls security certificates letsencrypt acme acmesharp + pki ssl tls security certificates letsencrypt acme acmesharp dnsmadeeasy - + diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 index 7c748172..619de7c8 100644 --- a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.psd1 @@ -12,16 +12,16 @@ ## This is a manifest-only module so we don't define any root #RootModule = '' - ModuleVersion = '0.8.5' - GUID = '7F6533CB-B35A-4E08-BD31-7561D0CC2A7B' + ModuleVersion = '0.9.0' + GUID = '9ea5edb1-319e-4f9d-a538-aec3567a410d' Author = 'https://github.com/ebekker' CompanyName = 'https://github.com/ebekker/ACMESharp' - Copyright = '(c) 2016 Jan-Pieter Zoutewelle. All rights reserved.' + Copyright = '(c) 2017 Matthew Steeple. All rights reserved.' - Description = "CloudFlare Provider extension library for ACMESharp Client." + Description = "DNS Made Easy Provider extension library for ACMESharp Client." # Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix. DefaultCommandPrefix = 'ACME' @@ -39,7 +39,7 @@ PSData = @{ # Tags applied to this module. These help with module discovery in online galleries. - Tags = @('pki','ssl','tls','security','certificates','letsencrypt','acme','powershell','acmesharp','cloudflare','acmesharp_ext') + Tags = @('pki','ssl','tls','security','certificates','letsencrypt','acme','powershell','acmesharp','dnsmadeeasy','acmesharp_ext') # A URL to the license for this module. LicenseUri = 'https://raw.githubusercontent.com/ebekker/ACMESharp/master/LICENSE' @@ -62,7 +62,7 @@ ## The minimum version of ACMESharp that supports our form of a Provider ## extension as a dynamically installed and *enabled* POSH Extension Module - , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + , @{ModuleName="ACMESharp";ModuleVersion="0.9.0"} ) diff --git a/ci/av-build.ps1 b/ci/av-build.ps1 index 1839d95f..e884f356 100644 --- a/ci/av-build.ps1 +++ b/ci/av-build.ps1 @@ -58,6 +58,7 @@ else { "ACMESharp.Providers.Windows" = @{} "ACMESharp.Providers.AWS" = @{} "ACMESharp.Providers.CloudFlare" = @{} + "ACMESharp.Providers.DNSMadeEasy" = @{} "ACMESharp.POSH" = @{ nugetBuildArgs = @("ACMESharp.POSH", "-Exclude", "README-TESTING.txt", "-Exclude", "en-us\*") nugetSkipPush = $false @@ -161,10 +162,11 @@ else { ## Embedded '@' overrides the default Project Folder "ACMESharp@ACMESharp.POSH" = $env:APPVEYOR_BUILD_VERSION ## After the 1.0 release, we'll sever the coupling in version numbers for these - "ACMESharp.Providers.IIS" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" - "ACMESharp.Providers.AWS" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" - "ACMESharp.Providers.CloudFlare" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" - "ACMESharp.Providers.Windows" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" + "ACMESharp.Providers.IIS" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" + "ACMESharp.Providers.AWS" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" + "ACMESharp.Providers.CloudFlare" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" + "ACMESharp.Providers.DNSMadeEasy" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" + "ACMESharp.Providers.Windows" = $env:APPVEYOR_BUILD_VERSION # "0.8.0.$($env:APPVEYOR_BUILD_NUMBER)" } foreach ($modName in $poshModules.Keys) { From 8b70cc612a69df8223776e38b1b6f800eb836093 Mon Sep 17 00:00:00 2001 From: Eugene Bekker Date: Thu, 26 Oct 2017 15:27:03 -0400 Subject: [PATCH 3/4] Fixing up version dependencies --- .../ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.nuspec | 2 +- ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.psd1 | 2 +- .../ACMESharp.Providers.CloudFlare.nuspec | 2 +- .../ACMESharp.Providers.CloudFlare.psd1 | 2 +- .../ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.nuspec | 2 +- ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.psd1 | 2 +- .../ACMESharp.Providers.Windows.nuspec | 2 +- .../ACMESharp.Providers.Windows.psd1 | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.nuspec b/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.nuspec index b018dd0e..d2ae866d 100644 --- a/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.nuspec +++ b/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.nuspec @@ -17,7 +17,7 @@ pki ssl tls security certificates letsencrypt acme acmesharp - + diff --git a/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.psd1 b/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.psd1 index 222a26ef..a0dcd1cf 100644 --- a/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.psd1 +++ b/ACMESharp/ACMESharp.Providers.AWS/ACMESharp.Providers.AWS.psd1 @@ -62,7 +62,7 @@ ## The minimum version of ACMESharp that supports our form of a Provider ## extension as a dynamically installed and *enabled* POSH Extension Module - , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + , @{ModuleName="ACMESharp";ModuleVersion="0.9.0"} ## We specify abolute min version, effectively *any* version , @{ModuleName="AWSPowerShell";ModuleVersion="0.0.1"} diff --git a/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.nuspec b/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.nuspec index b1fedfd8..9b6df5f0 100644 --- a/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.nuspec +++ b/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.nuspec @@ -17,7 +17,7 @@ pki ssl tls security certificates letsencrypt acme acmesharp - + diff --git a/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.psd1 b/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.psd1 index 7c748172..a2696874 100644 --- a/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.psd1 +++ b/ACMESharp/ACMESharp.Providers.CloudFlare/ACMESharp.Providers.CloudFlare.psd1 @@ -62,7 +62,7 @@ ## The minimum version of ACMESharp that supports our form of a Provider ## extension as a dynamically installed and *enabled* POSH Extension Module - , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + , @{ModuleName="ACMESharp";ModuleVersion="0.9.0"} ) diff --git a/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.nuspec b/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.nuspec index 87c26abb..17fcc351 100644 --- a/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.nuspec +++ b/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.nuspec @@ -17,7 +17,7 @@ pki ssl tls security certificates letsencrypt acme acmesharp - + diff --git a/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.psd1 b/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.psd1 index a632deb7..63784726 100644 --- a/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.psd1 +++ b/ACMESharp/ACMESharp.Providers.IIS/ACMESharp.Providers.IIS.psd1 @@ -62,7 +62,7 @@ ## The minimum version of ACMESharp that supports our form of a Provider ## extension as a dynamically installed and *enabled* POSH Extension Module - , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + , @{ModuleName="ACMESharp";ModuleVersion="0.9.0"} ) diff --git a/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.nuspec b/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.nuspec index cc863f1a..ced41293 100644 --- a/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.nuspec +++ b/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.nuspec @@ -17,7 +17,7 @@ pki ssl tls security certificates letsencrypt acme acmesharp - + diff --git a/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.psd1 b/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.psd1 index 288b2c26..7d934afd 100644 --- a/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.psd1 +++ b/ACMESharp/ACMESharp.Providers.Windows/ACMESharp.Providers.Windows.psd1 @@ -62,7 +62,7 @@ ## The minimum version of ACMESharp that supports our form of a Provider ## extension as a dynamically installed and *enabled* POSH Extension Module - , @{ModuleName="ACMESharp";ModuleVersion="0.8.2"} + , @{ModuleName="ACMESharp";ModuleVersion="0.9.0"} ) From 25442064168283a1b8f37c0a06b337a1c1900332 Mon Sep 17 00:00:00 2001 From: Eugene Bekker Date: Thu, 26 Oct 2017 15:28:37 -0400 Subject: [PATCH 4/4] Adding shared assembly details Removing dead class --- .../ACMESharp.Providers.DNSMadeEasy.csproj | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj index cc89965c..bf69e21e 100644 --- a/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj +++ b/ACMESharp/ACMESharp.Providers.DNSMadeEasy/ACMESharp.Providers.DNSMadeEasy.csproj @@ -44,7 +44,12 @@ - + + Properties\SharedAssemblyVersionInfo.cs + + + Properties\SharedGlobalSuppressions.cs + @@ -56,6 +61,9 @@ + + PreserveNewest +