Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --search-path-linker option to control linker options at build time #4697

Merged
merged 10 commits into from
Dec 9, 2024
Merged

add --search-path-linker option to control linker options at build time #4697

merged 10 commits into from
Dec 9, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Nov 7, 2024

Follow-up to #4645.

Add option --search-path-linker to control how linker options are handled at build time

  • same approach used as for --search-path-cpp-headers
  • default behaviour does not change, we continue to use LDFLAGS
  • added option to use LIBRARY_PATH instead

@lexming lexming added this to the 5.0 milestone Nov 7, 2024
@lexming lexming changed the title add option --search-path-linker to control how linker options at build time add option --search-path-linker to control linker options at build time Nov 10, 2024
@lexming lexming changed the title add option --search-path-linker to control linker options at build time add option search-path-linker to control linker options at build time Nov 11, 2024
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Nov 13, 2024
@lexming
Copy link
Contributor Author

lexming commented Dec 5, 2024

@Micket this should be easy to merge now that --search-path-cpp-headers is already merged

bartoldeman
bartoldeman approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 5e01424 into easybuilders:5.0.x Dec 9, 2024
39 checks passed
@lexming lexming deleted the search_path_lib branch December 9, 2024 16:08
@boegel boegel changed the title add option search-path-linker to control linker options at build time add --search-path-linker option to control linker options at build time Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
EasyBuild-5.0 EasyBuild 5.0 enhancement
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lexming @bartoldeman @boegel