Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable input prompts in GO, Net-SSLeay and MIME-Lite extensions of Perl-bundle-CPAN #22088

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Dec 21, 2024

(created using eb --new-pr)

The installation of Perl-bundle-CPAN is currently broken on 5.0.x. The extension GO, Net-SSLeay and MIME-Lite ask for question during installation.

Example for Net-SSLeay:

eb-shell> export OPENSSL_PREFIX=$EBROOTOPENSSL &&  perl Makefile.PL PREFIX=/user/brussel/101/vsc10122/easybuild/install/skylake/software/Perl-bundle-CPAN/5.38.2-GCCcore-13.3.0 --help
Do you want to run external tests?
These tests *will* *fail* if you do not have network connectivity. [n] n
*** If there are build errors, test failures or run-time malfunctions,
    try to use the same compiler and options to compile your OpenSSL,
    Perl, and Net::SSLeay.
*** Found OpenSSL-3.2.2 installed in /user/brussel/101/vsc10122/easybuild/install/skylake/software/OpenSSL/3
Generating a Unix-style Makefile
Writing Makefile for Net::SSLeay
Writing MYMETA.yml and MYMETA.json
eb-shell> exit

Somehow this seems to have worked in EB 4.9, although I don't see any QA defined for these PerlModules. Anyhow, this PR fixes this issues without black magic, by just patching the Makefile.PL of those package to use fixed settings and not ask any questions.

@lexming lexming changed the base branch from develop to 5.0.x December 21, 2024 00:17
@lexming lexming force-pushed the 20241221011524_new_pr_Perl-bundle-CPAN5361 branch from d5e3518 to c0c8271 Compare December 21, 2024 00:19
@lexming lexming added bug fix and removed change labels Dec 21, 2024
@lexming lexming added this to the 5.0 milestone Dec 21, 2024
@lexming
Copy link
Contributor Author

lexming commented Dec 21, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=22088 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_22088 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5473

Test results coming soon (I hope)...

- notification for comment with ID 2557910655 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/a2ffae3982b1510c54724dac1539a3d6 for a full test report.

@lexming lexming force-pushed the 20241221011524_new_pr_Perl-bundle-CPAN5361 branch 2 times, most recently from a04c09e to 801019b Compare December 21, 2024 11:21
@lexming lexming changed the title disable input prompts in go-db-perl extension of Perl-bundle-CPAN disable input prompts in GO and Net-SSLeay extensions of Perl-bundle-CPAN Dec 21, 2024
@lexming lexming force-pushed the 20241221011524_new_pr_Perl-bundle-CPAN5361 branch from 5b77cd1 to d2ad2cd Compare December 21, 2024 12:20
@lexming lexming changed the title disable input prompts in GO and Net-SSLeay extensions of Perl-bundle-CPAN disable input prompts in GO, Net-SSLeay and MIME-Lite extensions of Perl-bundle-CPAN Dec 21, 2024
@boegel
Copy link
Member

boegel commented Dec 21, 2024

@lexming I'm not seeing any hangs or input prompts being produced at all, so I think it's worth figuring out why you're hitting this while others are not...

@lexming
Copy link
Contributor Author

lexming commented Dec 22, 2024

Indeed, this is not the way forward. There are too many perl modules that actually use questions in their installs to be handled individually. Moreover, this should actually work with the existing easyconfigs, as it is the case in v4.9.

Closing to switch directions. Follow-up in #22094

@lexming lexming closed this Dec 22, 2024
@lexming lexming deleted the 20241221011524_new_pr_Perl-bundle-CPAN5361 branch December 22, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants