-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "{bio}[GCCcore/13.3.0] rDock v24.03.192" #22056
base: develop
Are you sure you want to change the base?
Revert "{bio}[GCCcore/13.3.0] rDock v24.03.192" #22056
Conversation
@boegelbot: please test @ generoso |
@sassy-crick: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2551992641 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
postinstallcmds = [ | ||
'sed -i "s|/bin/csh -f|/usr/bin/env tcsh|" %(installdir)s/bin/make_grid.csh ; ', | ||
'cp -ra %(builddir)s/%(name)s-%(version)s/scripts %(installdir)s ; ', | ||
'sed -i "s|/bin/csh -f|/usr/bin/env tcsh|" %(installdir)s/scripts/make_grid.csh ; ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, do we now have 2 make_grid.csh
copies, one in bin/ and one in scripts/ ?
are they the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, they are the same and I was wondering about that as well. As I don't know the program, I could not make an informed decision if that is what is expected, or not. It looks like all the files which are in the scripts
directory are also in bin
but bin
contains a additional files. I guess we can spare the copying of scripts
, so I have removed it. I have added the RBT_ROOT
path though as the user complained about something apparently missing, which was the result of that path not being set.
@boegelbot: please test @ generoso |
@sassy-crick: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2561111174 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@smoors Do you have any idea why the testbuild fails? It works for me with the |
Reverts #22012
The user informed me that two directories are missing as the
make install
does not install them.