Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "{bio}[GCCcore/13.3.0] rDock v24.03.192" #22056

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sassy-crick
Copy link
Collaborator

Reverts #22012
The user informed me that two directories are missing as the make install does not install them.

@sassy-crick
Copy link
Collaborator Author

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@sassy-crick: Request for testing this PR well received on login1

PR test command 'EB_PR=22056 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22056 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14885

Test results coming soon (I hope)...

- notification for comment with ID 2551992641 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/ba309710885124e922be3d3c76aa22ee for a full test report.

postinstallcmds = [
'sed -i "s|/bin/csh -f|/usr/bin/env tcsh|" %(installdir)s/bin/make_grid.csh ; ',
'cp -ra %(builddir)s/%(name)s-%(version)s/scripts %(installdir)s ; ',
'sed -i "s|/bin/csh -f|/usr/bin/env tcsh|" %(installdir)s/scripts/make_grid.csh ; ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do we now have 2 make_grid.csh copies, one in bin/ and one in scripts/ ?
are they the same?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, they are the same and I was wondering about that as well. As I don't know the program, I could not make an informed decision if that is what is expected, or not. It looks like all the files which are in the scripts directory are also in bin but bin contains a additional files. I guess we can spare the copying of scripts, so I have removed it. I have added the RBT_ROOT path though as the user complained about something apparently missing, which was the result of that path not being set.

@sassy-crick
Copy link
Collaborator Author

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@sassy-crick: Request for testing this PR well received on login1

PR test command 'EB_PR=22056 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22056 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14898

Test results coming soon (I hope)...

- notification for comment with ID 2561111174 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/08bcf58ea5403f0633df08efda055b15 for a full test report.

@sassy-crick
Copy link
Collaborator Author

@smoors Do you have any idea why the testbuild fails? It works for me with the 4.9.4 version of EasyBuild. Have there been changes in the framework?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants