Add build_target parameter to PythonPackage
#3575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `buildcmd` to pass options to `setup.py` is confusing and makes it impossible to fully replace the build command. Introduce `build_target` similar to `install_target` and deprecate passing a target and optional options via `buildcmd`. The old behavior is used when `buildcmd` is a known setup.py command such as `build` or `build_ext` or a single word, e.g. `clean`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
buildcmdto pass options tosetup.pyis confusing and makes it impossible to fully replace the build command.Introduce
build_targetsimilar toinstall_targetand deprecate passing a target and optional options viabuildcmd.The old behavior is used when
buildcmdis a known setup.py command such asbuildorbuild_extor a single word, e.g.clean.My first attempt was to only detect
buildcmd = '%(python)s ...'as an immediate fix for #3570 but that would limit us to much going forward when a Python package build uses a custom command like./build_wheel --fooIf this is acceptable I can open an accompanying PR to update the EasyConfigs to replace
buildcmd.