-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMMPS: generate version from the source files when using software-commit
#3485
base: develop
Are you sure you want to change the base?
Conversation
This pr has been test in the dev.eessi.io-example repository (EESSI/dev.eessi.io-example#8) and is also used to set up the following github action laraPPr/lammps#3. |
software-commit
software-commit
By merging with develop I now get the following error when testing
|
The error about the
The LICENSE file is now also copied to the installdir. Also tested the last commit in a github action see https://github.com/laraPPr/lammps/actions/runs/13077882201/job/36494374056. |
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Co-authored-by: ocaisa <alan.ocais@cecam.org>
@boegelbot please test @ jsc-zen3-a100 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2634085430 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laraPPr I've made some suggestions for improvements, mostly code cleanup.
I'll apply them and re-test myself so we can get this merged ASAP...
Please do not merge this one untill these two are merged I will update the easyBlock when the others get merged. The new additions is so that LAMMPS can be used with --software-commit for https://github.com/EESSI/dev.eessi.io-example.
processor_arch
) in LAMMPS easyblock #3484icx
on Intel Icelake systems #3321Currently
--module-only
does not work when the correct version is not specified. [RESOLVED]