Skip to content

Commit

Permalink
Transfer logfile from bundle to components
Browse files Browse the repository at this point in the history
This fixes the increased memory usage when running the EasyConfig test suite
as log files would stay open.

Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
  • Loading branch information
Thyre committed Nov 15, 2024
1 parent e3f74ad commit a18dce2
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions easybuild/easyblocks/generic/bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def __init__(self, *args, **kwargs):
if comp_cfg['patches']:
self.cfg.update('patches', comp_cfg['patches'])

self.comp_instances.append((comp_cfg, comp_cfg.easyblock(comp_cfg)))
self.comp_instances.append((comp_cfg, comp_cfg.easyblock(comp_cfg, logfile=self.logfile)))

self.cfg.update('checksums', checksums_patches)

Expand Down Expand Up @@ -320,9 +320,6 @@ def install_step(self):
new_val = path
env.setvar(envvar, new_val)

# close log for this component
comp.close_log()

def make_module_req_guess(self):
"""
Set module requirements from all comppnents, e.g. $PATH, etc.
Expand Down

0 comments on commit a18dce2

Please sign in to comment.