Relabel ice sizes as diameter, cloud optics by g-point or band, update API #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ice sizes are diameters, not radii
…p_compute_cld_from_pade at correct order
Correct cbind function arguments for cloud optics kernels
Fixes C++ API cloud bindings
updates: - [github.com/rhysd/actionlint: v1.7.6 → v1.7.7](rhysd/actionlint@v1.7.6...v1.7.7)
[pre-commit.ci] pre-commit autoupdate
Cloud optical properties can be suppled on bands or by g-point. --- Co-authored by: Michael J. Iacono <miacono@aer.com>
|
Hi Robert, I wonder why the Pade approximant cloud optics were removed? |
|
This is a question for @mjiacono |
|
It was not obvious how to develop the Pade approximant coefficients for the g-point optics, and we wanted to maintain consistency between the band and g-point cloud optics and to streamline future development. |
|
I see, thanks @mjiacono! |
* Add, update, and reformat documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ice particles are labeled as diameter (#309).
Cloud optical properties may be provided on bands or on g-points (#347)
C++ API to the cloud kernels are corrected (#345, #343)