From a7a648f333d712d1c20c9f4d60935c74d36c6bdd Mon Sep 17 00:00:00 2001 From: Rakesh Sojitra Date: Wed, 26 Jul 2023 17:29:25 +0530 Subject: [PATCH 1/2] build: version change to 5.0.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0aaf5ab..79d5a8e 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "version": "5.0.0", + "version": "5.0.1", "name": "ionic-selectable", "title": "Ionic Selectable", "description": "An Ionic component similar to Ionic Select, that allows to search items, including async search, group, add, edit, delete items, and much more.", From 5b9af7f158f428be9bbdc59545f91ef20a52b602 Mon Sep 17 00:00:00 2001 From: Rakesh Sojitra Date: Thu, 3 Aug 2023 19:56:28 +0530 Subject: [PATCH 2/2] fix: #424 and #425 issues --- index.ts | 16 ++++++++ package-lock.json | 4 +- package.json | 2 +- .../ionic-selectable-modal.component.html | 40 +------------------ .../ionic-selectable.component.ts | 11 +++-- 5 files changed, 26 insertions(+), 47 deletions(-) diff --git a/index.ts b/index.ts index fdcdb93..d3ec644 100644 --- a/index.ts +++ b/index.ts @@ -1 +1,17 @@ export * from './src/app/components/ionic-selectable/ionic-selectable.component'; +export * from './src/app/components/ionic-selectable/ionic-selectable-add-item-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-close-button-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-footer-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-group-end-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-group-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-header-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-icon-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-item-end-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-item-icon-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-item-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-message-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-modal.component'; +export * from './src/app/components/ionic-selectable/ionic-selectable-placeholder-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-search-fail-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-title-template.directive'; +export * from './src/app/components/ionic-selectable/ionic-selectable-value-template.directive'; diff --git a/package-lock.json b/package-lock.json index 97193f0..7eecd1f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "ionic-selectable", - "version": "5.0.0", + "version": "5.0.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "ionic-selectable", - "version": "5.0.0", + "version": "5.0.2", "license": "See license in LICENSE", "dependencies": { "cordova-android": "12.0.0", diff --git a/package.json b/package.json index 79d5a8e..9a6a271 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "version": "5.0.1", + "version": "5.0.2", "name": "ionic-selectable", "title": "Ionic Selectable", "description": "An Ionic component similar to Ionic Select, that allows to search items, including async search, group, add, edit, delete items, and much more.", diff --git a/src/app/components/ionic-selectable/ionic-selectable-modal.component.html b/src/app/components/ionic-selectable/ionic-selectable-modal.component.html index 2f4e8fa..cdad772 100644 --- a/src/app/components/ionic-selectable/ionic-selectable-modal.component.html +++ b/src/app/components/ionic-selectable/ionic-selectable-modal.component.html @@ -37,7 +37,7 @@
- + @@ -98,46 +98,10 @@ {{selectComponent.searchFailText}} - -
- - - - - - - {{selectComponent._formatItem(item)}} - -
-
-
-
- - - - - - - - - - -
-
diff --git a/src/app/components/ionic-selectable/ionic-selectable.component.ts b/src/app/components/ionic-selectable/ionic-selectable.component.ts index 8dee4f7..4aa5309 100644 --- a/src/app/components/ionic-selectable/ionic-selectable.component.ts +++ b/src/app/components/ionic-selectable/ionic-selectable.component.ts @@ -808,7 +808,7 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D private _element: ElementRef, private _renderer: Renderer2 ) { - if (!this.items || !this.items.length) { + if (!this.items?.length) { this.items = []; } @@ -955,7 +955,7 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D // Default filtering. let groups = []; - if (!this._searchText || !this._searchText.trim()) { + if (!this._searchText?.trim()) { groups = this._groups; } else { const filterText = this._searchText.trim().toLowerCase(); @@ -1197,7 +1197,7 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D private _areGroupsEmpty(groups: any) { return groups.length === 0 || groups.every((group: any) => { - return !group.items || group.items.length === 0; + return !group.items?.length; }); } @@ -1227,7 +1227,7 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D items: items || [] }]; - if (items && items.length) { + if (items?.length) { if (this._hasGroups) { groups = []; @@ -1366,7 +1366,6 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D if (itemsChanges) { this._setItems(this.items); - this.value = this.value; this.onItemsChange.emit({ component: this @@ -1629,7 +1628,7 @@ export class IonicSelectableComponent implements ControlValueAccessor, OnInit, D */ toggleItems(isSelect: boolean, items?: any[]) { if (isSelect) { - const hasItems = items && items.length; + const hasItems = items?.length; let itemsToToggle = this._groups.reduce((allItems, group) => { return allItems.concat(group.items); }, []);