Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[library] bump version of xmlresolver to 6.0.x #5604

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[library] bump version of xmlresolver to 6.0.x #5604

merged 3 commits into from
Jan 13, 2025

Conversation

dizzzz
Copy link
Member

@dizzzz dizzzz commented Jan 11, 2025 •
edited
Loading

To do: check start code

  • java client
  • server
  • docker container

replaces #5526 and #5461

@dizzzz dizzzz requested review from line-o, reinhapa and a team January 11, 2025 22:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dizzzz dizzzz marked this pull request as ready for review January 12, 2025 15:54
@duncdrum duncdrum self-requested a review January 12, 2025 16:32
duncdrum
duncdrum approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dizzzz container seems to be ok (according to tests on CI). If it isn't, we need to adjust the tests

@dizzzz
Copy link
Member Author

dizzzz commented Jan 13, 2025

@duncdrum it is that I don't have it clear how in the containers eXist is started. if it follows the normal route, we are OK.

@duncdrum
Copy link
Contributor

@dizzzz Dockerfile L-78-80

it runs: java org.exist.start.Main jetty

the relevant tests are steps 3 and 4

@dizzzz
Copy link
Member Author

dizzzz commented Jan 13, 2025

@duncdrum Then all is set and one :-) PR can be merged in...

@duncdrum duncdrum merged commit 9e32eca into eXist-db:develop Jan 13, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhapa reinhapa reinhapa approved these changes

@duncdrum duncdrum duncdrum approved these changes

@line-o line-o Awaiting requested review from line-o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dizzzz @duncdrum @reinhapa