Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): move .less files to style blocks #2407

Merged
merged 4 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-toys-sparkle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

Ensure custom styles are included in build
19 changes: 19 additions & 0 deletions src/components/ebay-3d-viewer/index.marko
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,22 @@ $ const {
<else><ebay-progress-spinner a11yText=a11yLoadText || 'Loading'/></else>
</div>
</div>

style {
.three-d-player {
position: relative;
}

.three-d-player__overlay {
position: absolute;
display: flex;
inset: 0;
flex-direction: column;
align-items: center;
justify-content: center;
}

.three-d-player__overlay--hidden {
display: none;
}
}
16 changes: 0 additions & 16 deletions src/components/ebay-3d-viewer/style.less

This file was deleted.

18 changes: 18 additions & 0 deletions src/components/ebay-bar-chart/index.marko
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,21 @@ $ const {
]>
<div.ebay-bar-chart__container id=component.getContainerId()/>
</div>

style {
.ebay-bar-chart {
width: 100%;
}

.ebay-bar-chart .highcharts-legend-item-hidden {
transition: fill 250ms;
}

.ebay-bar-chart .highcharts-legend-item-hidden .highcharts-point {
stroke-width: 0;
}

.highcharts-tooltip-container svg {
overflow: visible;
}
}
15 changes: 0 additions & 15 deletions src/components/ebay-bar-chart/style.less

This file was deleted.

34 changes: 34 additions & 0 deletions src/components/ebay-line-chart/index.marko
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,37 @@ $ const {
]>
<div.ebay-line-chart__container id=component.getContainerId()/>
</div>

style {
.ebay-line-chart {
width: 100%;
}

.ebay-line-chart__container {
height: 300px;
}

.ebay-line-chart .highcharts-point {
opacity: 0; /* overriding the default highcharts opacity to 0 so we can control it */
stroke-width: 2px; /* and adjusting the stroke width */
}

.ebay-line-chart .ebay-line-chart__marker--visible {
opacity: 1;
}

.ebay-line-chart .highcharts-legend-item .highcharts-point {
opacity: 1; /* displays the legend marker symbols which are hidden by the highcharts-point opacity */
stroke-width: 0; /* hide the default stroke */
}

.ebay-line-chart .highcharts-legend-item .highcharts-graph {
display: none; /* this hides a line strike through the marker symbols that we do not want */
}

@media (prefers-color-scheme: dark) {
.ebay-line-chart .highcharts-halo {
fill-opacity: 0.8; /* this inverses the default 0.2 fill opacity in from light mode */
}
}
}
31 changes: 0 additions & 31 deletions src/components/ebay-line-chart/style.less

This file was deleted.

28 changes: 28 additions & 0 deletions src/components/ebay-spark-line/index.marko
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,31 @@ $ const {
vector-effect="non-scaling-stroke"
/>
</svg>

style {
.ebay-spark-line {
width: 100%;
height: 100%;
max-width: 80px;
max-height: 30px;
transform: translate3d(0, 0, 0);
}

.ebay-spark-line__path {
fill: none;
stroke-width: 3px;
stroke-linecap: round;
}

.ebay-spark-line__path-neutral {
stroke: var(--spark-line-neutral, var(--color-data-viz-line-chart-primary));
}

.ebay-spark-line__path-positive {
stroke: var(--spark-line-positve, var(--color-data-viz-trend-positive));
}

.ebay-spark-line__path-negative {
stroke: var(--spark-line-negative, var(--color-data-viz-trend-negative));
}
}
25 changes: 0 additions & 25 deletions src/components/ebay-spark-line/style.less

This file was deleted.

Loading