Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release (next) #2405

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"mode": "pre",
"tag": "next",
"initialVersions": {
"@ebay/ebayui-core": "14.6.9"
},
"changesets": [
"breezy-toys-agree",
"fast-toys-sparkle",
"healthy-ducks-sip",
"lemon-mangos-thank",
"poor-mirrors-float",
"rotten-geckos-sniff",
"sharp-bees-grin",
"short-crabs-retire",
"sixty-experts-marry",
"smooth-rules-laugh",
"thirty-walls-notice",
"tidy-rockets-wonder",
"wet-wombats-roll"
]
}
4 changes: 2 additions & 2 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export default {
// Pre-bundle @storybook/addon-docs/blocks to avoid runtime errors
// This is needed because MDX documentation requires these blocks to be available
// during dynamic imports
include: ['@storybook/addon-docs/blocks']
}
include: ["@storybook/addon-docs/blocks"],
},
});
},
};
35 changes: 35 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,40 @@
# eBayUI-Core Changelog

## 15.0.0-next.0

### Major Changes

- [#2384](https://github.com/eBay/ebayui-core/pull/2384) [`aad6f91`](https://github.com/eBay/ebayui-core/commit/aad6f91497c136185490bbf6218a8d38b1dd3093) Thanks [@agliga](https://github.com/agliga)! - fix(combobox): remove view all options
`view-all-options` is no longer a valid option for combobox. Use `autocomplete: none` instead

- [#2357](https://github.com/eBay/ebayui-core/pull/2357) [`549c3c3`](https://github.com/eBay/ebayui-core/commit/549c3c3f7369df4d7e3d0ae0fb3d7549ee315c17) Thanks [@saiponnada](https://github.com/saiponnada)! - feat(ebay-accordion): new component

- [#2381](https://github.com/eBay/ebayui-core/pull/2381) [`02f0cd8`](https://github.com/eBay/ebayui-core/commit/02f0cd887d0eb073bb1378ef515aa9e4db9d4d0a) Thanks [@agliga](https://github.com/agliga)! - feat(dropdowns): added support for floating-ui

- [#2411](https://github.com/eBay/ebayui-core/pull/2411) [`57d2b60`](https://github.com/eBay/ebayui-core/commit/57d2b6009bdb25543845f30f0cc298d6d44a1c3f) Thanks [@agliga](https://github.com/agliga)! - chore: renamed ebay-fullscreen-dialog to ebay-fullscreen-dialog-deprecated and ebay-drawer-dialog to ebay-drawer-dialog-deprecated

- [#2406](https://github.com/eBay/ebayui-core/pull/2406) [`7dfbfce`](https://github.com/eBay/ebayui-core/commit/7dfbfce3d8b56d8895b130507666d5ce0010de43) Thanks [@agliga](https://github.com/agliga)! - chore: removed deprecated code

### Minor Changes

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`e40437c`](https://github.com/eBay/ebayui-core/commit/e40437cf8c2e301ed00958831e14996b2fec2757) Thanks [@github-actions](https://github.com/apps/github-actions)! - fix(ebay-table): update row-header attribute, removed aria-pressed

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`6bddc30`](https://github.com/eBay/ebayui-core/commit/6bddc309ac8ffbff98302ec88ecd403e5c962723) Thanks [@github-actions](https://github.com/apps/github-actions)! - Add area chart

### Patch Changes

- [#2407](https://github.com/eBay/ebayui-core/pull/2407) [`e40902f`](https://github.com/eBay/ebayui-core/commit/e40902f378ffdd69b79bab48356ada97725bd7a2) Thanks [@LuLaValva](https://github.com/LuLaValva)! - Ensure custom styles are included in build

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`c2b5b9d`](https://github.com/eBay/ebayui-core/commit/c2b5b9d6678516df4a7dc40aef5f37df1fad6b01) Thanks [@github-actions](https://github.com/apps/github-actions)! - Refactor to simplify types

- [#2408](https://github.com/eBay/ebayui-core/pull/2408) [`eb53ada`](https://github.com/eBay/ebayui-core/commit/eb53adaf7b1380ffa13292a844f47c00549c5cfe) Thanks [@LuLaValva](https://github.com/LuLaValva)! - Remove chevron from combobox

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`bd170c2`](https://github.com/eBay/ebayui-core/commit/bd170c2448a49d2e3cc8f7441063b94f9b1156c5) Thanks [@github-actions](https://github.com/apps/github-actions)! - TS fix for combobox

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`21197e5`](https://github.com/eBay/ebayui-core/commit/21197e55618b0c01fb522d6417307d0e4c6d4877) Thanks [@github-actions](https://github.com/apps/github-actions)! - Upgrade dependencies

- [#2405](https://github.com/eBay/ebayui-core/pull/2405) [`d316e9f`](https://github.com/eBay/ebayui-core/commit/d316e9f7eac27aea776d11ed5ed556c1928cfd9d) Thanks [@github-actions](https://github.com/apps/github-actions)! - Updated the component-browser.ts file to reference shared attributes from tags-html.d.ts and added the Textbox class implementation.

## 14.6.9

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ebay/ebayui-core",
"version": "14.6.9",
"version": "15.0.0-next.0",
"description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
"keywords": [
"marko-components"
Expand Down
4 changes: 1 addition & 3 deletions src/common/charts/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,12 @@ export const chartFontFamily = '"Market Sans", Arial, sans-serif',
if (series[i].type === "bar") {
(series[i] as Highcharts.SeriesBarOptions).borderColor = color;
(series[i] as Highcharts.SeriesBarOptions).color = color;
}
else {
} else {
(series[i] as Highcharts.SeriesAreaOptions).lineColor = color;
(series[i] as Highcharts.SeriesAreaOptions).fillOpacity = 1;
}
}
},

setDonutColors = function (series: any) {
const colors = [
{ lineColor: chartPrimaryColor, borderColor: chartPrimaryColor },
Expand Down
10 changes: 7 additions & 3 deletions src/common/dropdown/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import {
computePosition,
shift,
offset,
type ReferenceElement
type ReferenceElement,
} from "@floating-ui/dom";

interface DropdownUtilOptions {
reverse?: boolean;
offset?: number
offset?: number;
}

export class DropdownUtil {
Expand All @@ -18,7 +18,11 @@ export class DropdownUtil {
declare cleanupFn: any;
declare options: DropdownUtilOptions;

constructor(host: HTMLElement, overlay: HTMLElement, options?: DropdownUtilOptions) {
constructor(
host: HTMLElement,
overlay: HTMLElement,
options?: DropdownUtilOptions,
) {
this.host = host as ReferenceElement;
this.overlay = overlay as HTMLElement;
this.options = options ?? {};
Expand Down
6 changes: 3 additions & 3 deletions src/components/ebay-accordion/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@

## Examples and Documentation

- [Storybook](https://ebay.github.io/ebayui-core/?path=/story/navigation-disclosure-ebay-accordion)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/navigation-disclosure-ebay-accordion)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-accordion/examples)
- [Storybook](https://ebay.github.io/ebayui-core/?path=/story/navigation-disclosure-ebay-accordion)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/navigation-disclosure-ebay-accordion)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-accordion/examples)
3 changes: 2 additions & 1 deletion src/components/ebay-accordion/accordion.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ export default {
},
onToggle: {
action: "on-toggle",
description: "Triggered on toggle of details to control auto-collapse",
description:
"Triggered on toggle of details to control auto-collapse",
table: {
category: "Events",
defaultValue: {
Expand Down
10 changes: 6 additions & 4 deletions src/components/ebay-accordion/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ class Accordion extends Marko.Component<Input, State> {
};
}

handleToggle(index: number, event: { originalEvent: Event; open: boolean; }) {

handleToggle(
index: number,
event: { originalEvent: Event; open: boolean },
) {
const { autoCollapse } = this.input;
if(autoCollapse && event.open) {
if (autoCollapse && event.open) {
this.state.index = index;
}

this.emit("toggle", {
originalEvent: event.originalEvent,
open: (event.originalEvent.target as HTMLDetailsElement).open,
Expand Down
6 changes: 3 additions & 3 deletions src/components/ebay-area-chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ The area chart displays one to five series of data points as an interactive stac

## Examples and Documentation

- [Storybook](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-area-chart/examples)
- [Storybook](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-area-chart/examples)
4 changes: 2 additions & 2 deletions src/components/ebay-area-chart/area-chart.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const seriesDataWithoutLabels = sampleSeriesData.map((series) => {
return rest;
}),
};
})
});

export default {
title: "charts/ebay-area-chart",
Expand Down Expand Up @@ -226,4 +226,4 @@ CustomHighchartOptions.args = {
tickAmount: 4,
},
},
};
};
2 changes: 1 addition & 1 deletion src/components/ebay-bar-chart/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class BarChart extends Marko.Component<Input> {
: [this.input.series];
const stacked = this.input.stacked;
const title = this.input.title;

// controls rounded corders and spacing at the bottom of data points
if (stacked) {
series[0].bottom = true; // set a variable on the first series so it renders rounder corners on the bottom of the bar
Expand Down
5 changes: 4 additions & 1 deletion src/components/ebay-date-textbox/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ class DateTextbox extends Marko.Component<Input, State> {
autoCollapse: true,
});

this.dropdownUtil = new DropdownUtil(this.el as HTMLElement, this.getEl("popover"))
this.dropdownUtil = new DropdownUtil(
this.el as HTMLElement,
this.getEl("popover"),
);
}

onDestroy() {
Expand Down
6 changes: 3 additions & 3 deletions src/components/ebay-details/details.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export default {
renderBody: {},
summary: {
name: "@summary",
description: "The body which will be wrapped as the details summary",
description:
"The body which will be wrapped as the details summary",
table: {
category: "@attribute tags",
},
Expand Down Expand Up @@ -91,8 +92,7 @@ export default {

export const Standard = Template.bind({});
Standard.args = {
renderBody:
`Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.`,
renderBody: `Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.`,
summary: {
renderBody: `Show me details!`,
},
Expand Down
5 changes: 2 additions & 3 deletions src/components/ebay-filter-menu-button/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,9 @@ export default class extends MenuUtils<Input, MenuState> {
this.getEl("button"),
this.getEl("menu"),
{
offset: 8
}
offset: 8,
},
);

}

_cleanupMakeup() {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-line-chart/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ declare const Highcharts: typeof HighchartsTypes;

interface SeriesLineOptions extends Highcharts.PlotLineOptions {
data: Highcharts.PointOptionsObject[];
type: "line",
type: "line";
}

interface LineChartInput extends Omit<Marko.HTML.Div, `on${string}` | "title"> {
Expand Down
5 changes: 4 additions & 1 deletion src/components/ebay-listbox-button/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ class ListboxButton extends Marko.Component<Input, State> {

scrollKeyPreventer.add(this.getEl("button"));
}
this.dropdownUtil = new DropdownUtil(this.getEl("button"), this.getEl("options"))
this.dropdownUtil = new DropdownUtil(
this.getEl("button"),
this.getEl("options"),
);
}

_cleanupMakeup() {
Expand Down
4 changes: 2 additions & 2 deletions src/components/ebay-menu-button/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ export default class extends MenuUtils<Input, MenuState> {
this.getEl("button"),
this.getEl("content"),
{
reverse: this.input.reverse
}
reverse: this.input.reverse,
},
);
}

Expand Down
7 changes: 1 addition & 6 deletions src/components/ebay-table/table.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,7 @@ export default {
columnType: {
name: "column-type",
control: { type: "select" },
options: [
"normal",
"numeric",
"layout",
"icon-action",
],
options: ["normal", "numeric", "layout", "icon-action"],
table: {
category: "@header attribute tags",
defaultValue: {
Expand Down