Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revered combobox view all options state code #2402

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 23, 2025

Description

From a previous PR, we had viewAllOptions state variable removed. This should not have been done and only should have been done as changing input. This change does that
We can discusss to remove viewAllOptions next major

References

#2284

@agliga agliga self-assigned this Jan 23, 2025
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 092d50c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit 6fea187 into master Jan 23, 2025
5 checks passed
@agliga agliga deleted the revert-combobox branch January 23, 2025 18:18
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants