Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release (next) #2393

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"mode": "pre",
"tag": "next",
"initialVersions": {
"@ebay/ebayui-core": "14.6.8"
},
"changesets": [
"sharp-bees-grin",
"sixty-experts-marry",
"thirty-walls-notice",
"wet-wombats-roll"
]
}
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# eBayUI-Core Changelog

## 14.7.0-next.0

### Minor Changes

- [#2384](https://github.com/eBay/ebayui-core/pull/2384) [`38cb097`](https://github.com/eBay/ebayui-core/commit/38cb09726602a74995e42f11dbc67abd7a8f9844) Thanks [@agliga](https://github.com/agliga)! - Add area chart

### Patch Changes

- [#2384](https://github.com/eBay/ebayui-core/pull/2384) [`6755659`](https://github.com/eBay/ebayui-core/commit/675565960b6196cc8d244e4ac96b2a736c13907a) Thanks [@agliga](https://github.com/agliga)! - TS fix for combobox

- [#2384](https://github.com/eBay/ebayui-core/pull/2384) [`ed4ed54`](https://github.com/eBay/ebayui-core/commit/ed4ed54f93c3cbc4230c8f4938a38c75eb79b2eb) Thanks [@agliga](https://github.com/agliga)! - Upgrade dependencies

- [#2384](https://github.com/eBay/ebayui-core/pull/2384) [`4aaa0c8`](https://github.com/eBay/ebayui-core/commit/4aaa0c8a29c91cea172bc6cd4d2c1d56ee557c88) Thanks [@agliga](https://github.com/agliga)! - Updated the component-browser.ts file to reference shared attributes from tags-html.d.ts and added the Textbox class implementation.

## 14.6.8

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ebay/ebayui-core",
"version": "14.6.8",
"version": "14.7.0-next.0",
"description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
"keywords": [
"marko-components"
Expand Down
4 changes: 1 addition & 3 deletions src/common/charts/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,12 @@ export const chartFontFamily = '"Market Sans", Arial, sans-serif',
if (series[i].type === "bar") {
(series[i] as Highcharts.SeriesBarOptions).borderColor = color;
(series[i] as Highcharts.SeriesBarOptions).color = color;
}
else {
} else {
(series[i] as Highcharts.SeriesAreaOptions).lineColor = color;
(series[i] as Highcharts.SeriesAreaOptions).fillOpacity = 1;
}
}
},

setDonutColors = function (series: any) {
const colors = [
{ lineColor: chartPrimaryColor, borderColor: chartPrimaryColor },
Expand Down
6 changes: 3 additions & 3 deletions src/components/ebay-area-chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ The area chart displays one to five series of data points as an interactive stac

## Examples and Documentation

- [Storybook](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-area-chart/examples)
- [Storybook](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-area-chart/examples)
4 changes: 2 additions & 2 deletions src/components/ebay-area-chart/area-chart.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const seriesDataWithoutLabels = sampleSeriesData.map((series) => {
return rest;
}),
};
})
});

export default {
title: "charts/ebay-area-chart",
Expand Down Expand Up @@ -226,4 +226,4 @@ CustomHighchartOptions.args = {
tickAmount: 4,
},
},
};
};
2 changes: 1 addition & 1 deletion src/components/ebay-bar-chart/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class BarChart extends Marko.Component<Input> {
: [this.input.series];
const stacked = this.input.stacked;
const title = this.input.title;

// controls rounded corders and spacing at the bottom of data points
if (stacked) {
series[0].bottom = true; // set a variable on the first series so it renders rounder corners on the bottom of the bar
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-line-chart/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ declare const Highcharts: typeof HighchartsTypes;

interface SeriesLineOptions extends Highcharts.PlotLineOptions {
data: Highcharts.PointOptionsObject[];
type: "line",
type: "line";
}

interface LineChartInput
Expand Down
9 changes: 6 additions & 3 deletions src/components/ebay-textbox/component-browser.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import FloatingLabel from "makeup-floating-label";
import type { WithNormalizedProps } from "../../global";
import type { AttrOnOff, AttrString, AttrStringOrNumber } from "marko/tags-html";
import type {
AttrOnOff,
AttrString,
AttrStringOrNumber,
} from "marko/tags-html";

export interface TextboxEvent {
originalEvent: Event;
Expand Down Expand Up @@ -35,7 +39,6 @@ interface TextboxInput extends Omit<Marko.Input<"input">, `on${string}`> {
autocorrect?: AttrOnOff;
cols?: AttrStringOrNumber;
rows?: AttrStringOrNumber;

}

export interface Input extends WithNormalizedProps<TextboxInput> {}
Expand Down Expand Up @@ -100,4 +103,4 @@ class Textbox extends Marko.Component<Input> {
}
}

export default Textbox;
export default Textbox;