Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): remove view all options #2384

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(combobox): remove view all options #2384

merged 1 commit into from
Jan 23, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 16, 2025

Description

  • Removed view all options
  • Updated tests to use autocomplete:none
  • Added an example to show all options (Im happy to remove it or actually display it on storybook, but I kept it in examples only until we decide what the right course of action is).

References

#2383

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cfb4cbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga force-pushed the remove-view-all-optons branch 2 times, most recently from ad7d2cb to ad9f4c4 Compare January 16, 2025 17:23
@agliga agliga force-pushed the remove-view-all-optons branch from ad9f4c4 to dccb53c Compare January 16, 2025 19:26
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Closed
@agliga agliga self-assigned this Jan 16, 2025
@agliga agliga requested a review from WinkeeFace January 16, 2025 20:13
@agliga agliga force-pushed the remove-view-all-optons branch from dccb53c to 11ecefd Compare January 18, 2025 00:21
@github-actions github-actions bot mentioned this pull request Jan 18, 2025
Closed
@agliga agliga force-pushed the 15.0.0 branch 3 times, most recently from 3f319bc to c2b5b9d Compare January 23, 2025 18:32
@agliga agliga force-pushed the remove-view-all-optons branch from 11ecefd to cfb4cbd Compare January 23, 2025 18:40
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Closed
@agliga agliga merged commit aad6f91 into 15.0.0 Jan 23, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLaValva LuLaValva LuLaValva approved these changes

@HenriqueLimas HenriqueLimas HenriqueLimas approved these changes

@ArtBlue ArtBlue Awaiting requested review from ArtBlue

@saiponnada saiponnada Awaiting requested review from saiponnada

@WinkeeFace WinkeeFace Awaiting requested review from WinkeeFace

Assignees

@agliga agliga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agliga @HenriqueLimas @LuLaValva