chore: upgrade marko & mtc, fix type errors #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fca391e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agliga
approved these changes
Jan 14, 2025
Closed
agliga
pushed a commit
that referenced
this pull request
Jan 16, 2025
agliga
pushed a commit
that referenced
this pull request
Jan 18, 2025
agliga
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
marko,@marko/type-check, and@marko/compilerto latesttype-checkupgrade exposed a few types that were wrong in eBayUI, this fixes each of them.Note
The
ebay-breadcrumbsexample that I changed includes a few attributes which only make sense in some ebay apps, so they are not valid in types. Teams who need to include extra attributes should overrideMarko.HTML.Navin their project, but that shouldn't happen in eBayUI.