Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ebay-combobox): floating label type #2370

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(ebay-combobox): floating label type #2370

merged 1 commit into from
Jan 15, 2025

Conversation

MaiDeveloper
Copy link

Description

The floating-label property in the combobox component is currently set as a boolean value, but it should be defined as a string instead.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5f7656b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LuLaValva
LuLaValva reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick PR! Before merging, can you npm run change to add a changeset? Description can be super simple, something like "TS fix for combobox" is fine. This will kick off our release cycle. Added bonus is the CI will give you credit in the patch notes 😉

@MaiDeveloper MaiDeveloper requested a review from LuLaValva January 9, 2025 16:59
@agliga
Copy link
Contributor

agliga commented Jan 9, 2025

We also need an issue to track this first.

@LuLaValva LuLaValva linked an issue Jan 9, 2025 that may be closed by this pull request
ebay-combobox: floating label incorrect type #2371
Closed
@MaiDeveloper MaiDeveloper changed the base branch from master to changeset-release/15.0.0 January 9, 2025 17:49
@MaiDeveloper MaiDeveloper force-pushed the fix-combobox-floating-label-type branch 2 times, most recently from c726cce to 1f33552 Compare January 9, 2025 18:13
@agliga agliga changed the base branch from changeset-release/15.0.0 to 15.0.0 January 9, 2025 22:28
@agliga
Copy link
Contributor

agliga commented Jan 9, 2025 •
edited
Loading

So there are a couple of extra files. Can you maybe undo the commit and merge from 15.0.0, not the changesets/15.0.0 branch?
I went ahead and targeted the 15.0.0 branch

@MaiDeveloper MaiDeveloper force-pushed the fix-combobox-floating-label-type branch from 1f33552 to 5f7656b Compare January 10, 2025 00:39
@MaiDeveloper
Copy link
Author

Done

@agliga agliga merged commit 674712a into eBay:15.0.0 Jan 15, 2025
4 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Closed
agliga pushed a commit that referenced this pull request Jan 16, 2025
@MaiDeveloper @agliga
fix(ebay-combobox): floating label type (#2370)
2cb19b1
agliga pushed a commit that referenced this pull request Jan 18, 2025
@MaiDeveloper @agliga
fix(ebay-combobox): floating label type (#2370)
6755659
agliga pushed a commit that referenced this pull request Jan 23, 2025
@MaiDeveloper @agliga
fix(ebay-combobox): floating label type (#2370)
bd170c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLaValva LuLaValva LuLaValva approved these changes

@agliga agliga agliga approved these changes

Assignees

@MaiDeveloper MaiDeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebay-combobox: floating label incorrect type
3 participants
@MaiDeveloper @agliga @LuLaValva