fix(ebay-textbox): update input interface to include textarea-specifi… #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c30ab45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LuLaValva
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Thanks @WinkeeFace, looks good! Just one quick fix.
Also, can you npm run change? Looks like you're missing a changeset, this should be a patch.
…-and-other-input-attributes-1' of https://github.com/eBay/ebayui-core into 2356-ebay-textbox-typescript-type-check-breaks-for-step-and-other-input-attributes
LuLaValva
approved these changes
Jan 8, 2025
agliga
approved these changes
Jan 9, 2025
agliga
deleted the
2356-ebay-textbox-typescript-type-check-breaks-for-step-and-other-input-attributes-1
branch
Closed
agliga
pushed a commit
that referenced
this pull request
Jan 16, 2025
agliga
pushed a commit
that referenced
this pull request
Jan 18, 2025
agliga
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
component-browser.tsfile to reference shared attributes fromtags-html.d.tsand added theTextboxclass implementation.Context
These changes were made to reduce redundancy and ensure a single source of truth for the attributes used in the
TextboxInputinterface. By referencing the shared attributes, we can maintain consistency and avoid potential errors. Additionally, theTextboxclass was implemented to handle the floating label functionality and event forwarding.References
Fixes #2356
Screenshots
N/A