Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebay-area-chart): refactor existing area chart to design specs #2358

Merged
merged 17 commits into from
Jan 15, 2025

Conversation

mikehobi
Copy link
Contributor

@mikehobi mikehobi commented Jan 2, 2025

Description

  • Un-ignores existing ebay-area-chart component
  • Simplify axis logic
  • Simplify label formatting
  • Allows for custom Highcharts configuration for more custom implementations

Context

Create a reusable donut chart based on DS Data Viz component design

Github issue: #2075

Screenshots

image image image

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: 63d7a6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikehobi mikehobi closed this Jan 2, 2025
@mikehobi mikehobi reopened this Jan 2, 2025
@mikehobi mikehobi changed the base branch from master to 15.0.0 January 2, 2025 17:20
@mikehobi mikehobi changed the title 2075 area chart feat(ebay-area-chart): refactor existing area chart to design specs Jan 6, 2025
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me
Can we revert all those extra readme spacing changes? Or at least make sure this has the latest code from 15.0.0?

@mikehobi
Copy link
Contributor Author

mikehobi commented Jan 9, 2025

Overall it looks good to me Can we revert all those extra readme spacing changes? Or at least make sure this has the latest code from 15.0.0?

@agliga yes! don't know where those came from

@agliga agliga merged commit f3513e6 into 15.0.0 Jan 15, 2025
5 checks passed
@agliga agliga deleted the 2075-area-chart branch January 15, 2025 16:07
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants