Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebay-accordion): new component #2357

Merged
merged 5 commits into from
Jan 24, 2025
Merged

feat(ebay-accordion): new component #2357

merged 5 commits into from
Jan 24, 2025

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Dec 31, 2024

Description

  • Added new accordion component.

References

#2339

Copy link

changeset-bot bot commented Dec 31, 2024

🦋 Changeset detected

Latest commit: 66e21a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saiponnada saiponnada requested review from agliga and LuLaValva January 3, 2025 20:22
@saiponnada saiponnada self-assigned this Jan 3, 2025
@saiponnada saiponnada marked this pull request as ready for review January 3, 2025 20:22
@saiponnada saiponnada requested a review from ArtBlue January 3, 2025 20:23
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have another change going through for this version where all items are now singular (this is mainly for fixing some issues that marko 4 introduced). So going forward all attribute tags should have the same name both in code and in input.
So change all the input.items to be input.item (but still an array)

src/components/ebay-accordion/accordion.stories.ts Outdated Show resolved Hide resolved
src/components/ebay-accordion/component-browser.ts Outdated Show resolved Hide resolved
src/components/ebay-accordion/marko-tag.json Outdated Show resolved Hide resolved
@agliga
Copy link
Contributor

agliga commented Jan 9, 2025

@saiponnada
For the template, lets do this

$ const {
  item: items = []
} = input

<for|item| of=items></for>

That way we read input.item but we have it in code as items

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, a minor nit and a question about variable name change.
I think its ready to go otherwise.

src/components/ebay-accordion/index.marko Outdated Show resolved Hide resolved
src/components/ebay-accordion/index.marko Outdated Show resolved Hide resolved
@agliga agliga force-pushed the 15.0.0 branch 2 times, most recently from 57363a8 to c37cb09 Compare January 21, 2025 20:15
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
But we should be toggling things using markos way of toggling things rather than dom manipulation

src/components/ebay-accordion/component-browser.ts Outdated Show resolved Hide resolved
src/components/ebay-accordion/component-browser.ts Outdated Show resolved Hide resolved
@saiponnada saiponnada merged commit 549c3c3 into 15.0.0 Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants