-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ebay-accordion): new component #2357
Conversation
🦋 Changeset detectedLatest commit: 66e21a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have another change going through for this version where all items are now singular (this is mainly for fixing some issues that marko 4 introduced). So going forward all attribute tags should have the same name both in code and in input.
So change all the input.items
to be input.item
(but still an array)
@saiponnada
That way we read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, a minor nit and a question about variable name change.
I think its ready to go otherwise.
57363a8
to
c37cb09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
But we should be toggling things using markos way of toggling things rather than dom manipulation
Description
References
#2339