fix(table): replaced column-type of "row-header" with boolean row-header #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuLaValva
reviewed
Dec 31, 2024
There was a problem hiding this comment.
Well done, thanks @WinkeeFace! Just a few notes:
- Those tests are failing because you didn't include
rowHeaderin theindex.markodestructure here. - Since Marko 5 / eBayUI normalizes kebab-case to camelCase so both are accepted, that needs to be accommodated for in TypeScript. To do this, you can either add duplicate
"row-header"?: boolean;and"column-type"?: ...types in the interface (probably not recommended), or you can switch everything to kebab-case and useWithNormalizedProps<>like we do forInput(preferred). =trueis implied in Marko attributes (same as HTML), so there are a few examples that can be simplified (I showed one example in a code comment)
Thank you for the feedback! I'll make those corrections. |
🦋 Changeset detectedLatest commit: 59159b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Also please add a changeset! Thanks! |
WinkeeFace
changed the title
…ay/ebayui-core into 2313-ebay-table-various-fixes
|
@WinkeeFace I appreciate the effort of going through and adding |
agliga
requested changes
Jan 14, 2025
…ay/ebayui-core into 2313-ebay-table-various-fixes
author jwink <Joshf.wink@gmail.com> 1735049444 -0600 committer jwink <Joshf.wink@gmail.com> 1737052644 -0600 gpgsig -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSoShVR892P7bJRQArkPu1hwhBhDwUCZ4lR5AAKCRDkPu1hwhBh D0izAQDhhUyjnmvyZHTgn+gtb1drZh748Tmum8YTx0gtdWQ9fQD/Wxma9Y+QI7iE DjGrDfkF1dBV31gbsJ2FdJVwlUPdbA8= =K8Tx -----END PGP SIGNATURE----- parent df32cbb author jwink <Joshf.wink@gmail.com> 1735049444 -0600 committer jwink <Joshf.wink@gmail.com> 1737052605 -0600 gpgsig -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSoShVR892P7bJRQArkPu1hwhBhDwUCZ4lRvQAKCRDkPu1hwhBh D2dZAQDNsHo6luNAbuTqpJv8XWYlDvo5XTt3V039M31yvSisZgD/UmYJRTPcXvAh 9Juaec5xArHCQ2TKIduoEOglHOVnTQM= =U5up -----END PGP SIGNATURE----- parent df32cbb author jwink <Joshf.wink@gmail.com> 1735049444 -0600 committer jwink <Joshf.wink@gmail.com> 1737052478 -0600 gpgsig -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSoShVR892P7bJRQArkPu1hwhBhDwUCZ4lRPgAKCRDkPu1hwhBh D1GbAQCba0MBp0W324agRMrWxOdsC5eddIIPTF4X+DTLxaFrPAEA82VWkg8uGsvf G7zhgr/F27UtC4NyWmVyyB8ncXnoTQs= =5TPI -----END PGP SIGNATURE----- parent df32cbb author jwink <Joshf.wink@gmail.com> 1735049444 -0600 committer jwink <Joshf.wink@gmail.com> 1737052214 -0600 gpgsig -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSoShVR892P7bJRQArkPu1hwhBhDwUCZ4lQNgAKCRDkPu1hwhBh D1ZUAP0WPGOj9dOX7yYUjlBm9pwMrfrRwZY/bWgm1qxlSwMhPgD/c9VXZ3LJzrEz RiRCESkQvdmXjFEcDvQH2cI95afvHQo= =W7De -----END PGP SIGNATURE----- feat(table): replaced column-type of row-header with boolean row-header feat(table): update row-header attribute to boolean format in examples feat(table): update row-header attribute to boolean format in examples feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples feat(table): replaced column-type of row-header with boolean row-header feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples fix(ebay-table): remove aria-pressed attribute for improved accessibility chore: remove .DS_Store files and update .gitignore feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples feat(table): replaced column-type of row-header with boolean row-header feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples fix(ebay-table): remove aria-pressed attribute for improved accessibility chore: remove .DS_Store files and update .gitignore feat(table): replaced column-type of row-header with boolean row-header feat(table): update TableHeader interface and examples to use WithNormalizedProps fix(table): update examples to use 'as const' for column-type attributes fix(table): update examples to use 'as const' for numeric column-type fix(table): update examples to use 'as const' for numeric column-type headers fix(table): remove 'as const' from numeric column-type headers in examples chore: remove .DS_Store files and update .gitignore
…ay/ebayui-core into 2313-ebay-table-various-fixes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
column-typeofrow-headerwith a booleanrow-headerin theebay-tablecomponent. Updated the relevant Marko and JSON files to reflect this change.Context
This change was made to simplify the handling of row headers and improve ARIA accessibility. The boolean
row-headeris more intuitive and aligns better with accessibility standards.References
Screenshots
N/A