Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(highcharts): use dynamic import instead of CDN, with lasso polyfill #2080

Closed
wants to merge 2 commits into from

Conversation

LuLaValva
Copy link
Member

Description

  • Use dynamic import instead of CDN, with lasso polyfill

Context

  • Highcharts was not working on storybook, and some apps reported that it caused errors.

@LuLaValva LuLaValva self-assigned this Jan 30, 2024
@agliga
Copy link
Contributor

agliga commented Jan 31, 2024

Not sure why this is changed. This was working before SWU.

We should not change it like this becasue this will block pages loading. We want to load it after the fact.

I don't think this is the right fix.

@LuLaValva
Copy link
Member Author

This is not blocking to the render because it is a dynamic import, but I agree it may not be the right fix. We should discuss with @DylanPiercey before moving forward.

@agliga
Copy link
Contributor

agliga commented Jan 31, 2024

This is not blocking to the render because it is a dynamic import, but I agree it may not be the right fix. We should discuss with @DylanPiercey before moving forward.

So one more issue. There is an issue assigned to me this sprint. I had already started to look at it but this seems very inefficient since we're both doing the same thing
I would also add this has two different fixes, one for charts and one for tooltip. We need to have these in separate prs.
Please reach out to me before implementing changes so we can discuss and not have throw away code.

@LuLaValva
Copy link
Member Author

Closing in favor of #2083

@LuLaValva LuLaValva closed this Feb 1, 2024
@agliga agliga deleted the highcharts-fix branch March 22, 2024 16:26
@agliga agliga restored the highcharts-fix branch March 22, 2024 16:26
@agliga agliga deleted the highcharts-fix branch September 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants