Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select,combobox): added disabled to input #2068

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(select,combobox): added disabled to input #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ebay-combobox/index.marko
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ $ var id = inputId || component.getElId("input");
key="combobox"
type="text"
role="combobox"
disabled=disabled
value=state.currentValue
aria-autocomplete=component.autocomplete
aria-roledescription=roledescription
Expand Down
1 change: 1 addition & 0 deletions src/components/ebay-select/index.marko
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ $ for (const option of options) {
style=style>
<select
...processHtmlAttributes(htmlInput)
disabled=disabled
id=id
onChange("handleChange")>
<for|optionOrGroup| of=list>
Expand Down
Loading