Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: destructure input when possible #2039

Merged
merged 6 commits into from
Dec 23, 2023
Merged

refactor: destructure input when possible #2039

merged 6 commits into from
Dec 23, 2023

Conversation

LuLaValva
Copy link
Member

Description

  • Almost completely eliminate the ignoredAttributes pattern, and replace it with a destructure of input
  • ignoredAttributes couldn't be completely removed without a larger refactor, which could happen in a future PR
  • This refactor revealed oversights that were made alongside the previous pattern, so snapshot/test changes should all be viewed as bug fixes. No intended behavior was modified in this PR.

@LuLaValva LuLaValva self-assigned this Dec 22, 2023
agliga
agliga approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this new set of changes. Looks great.
Well test it thoroughly next week.

@agliga agliga merged commit 9eb0de5 into 13.0.0 Dec 23, 2023
1 check passed
@agliga agliga deleted the 1927-ignored-attributes branch December 23, 2023 03:12
@mkchang mkchang mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@ianmcburnie ianmcburnie Awaiting requested review from ianmcburnie

@ArtBlue ArtBlue Awaiting requested review from ArtBlue

@saiponnada saiponnada Awaiting requested review from saiponnada

Assignees

@LuLaValva LuLaValva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuLaValva @agliga @saiponnada