feat(tooltip): swapped to use floatingui #2037

agliga · 2023-12-14T01:33:36Z

Description

Added floating ui to tooltip.
At the moment left it to use limited positions.
There might be a bug with positions but I think its a skin issue.
This depends on the typescript PR to be merged first.

…atingui

LuLaValva

Looks good, thanks Andrew! The only problem I noticed was that popper didn't change when the size of the container it was labeling changed (i. e. via screen resize), but I think that may be a limitation of floatingui and not your implementation

list

LuLaValva

Quick comment, but you don't have to change it. I think you're good to merge.

src/components/components/ebay-tooltip-base/constants.ts

LuLaValva added 30 commits April 11, 2023 15:18

feat: switch to ts mode

6c4eed5

feat(body-scroll): convert to ts

3acaf30

feat(build-safe-regex): convert to ts

2a6574e

feat(cdn): convert to ts

dff0247

feat(dom): convert to ts

12cccbb

feat(element-scroll): convert to ts

7279987

feat(event-utils): convert to ts

4482d02

feat(html-attributes): convert to ts

4720274

feat(loader): convert to ts

255cb2a

feat(transition): convert to ts

1ea335d

feat(dialog-base): convert to ts

2f0a7c0

feat(notice-base): convert to ts

1966d4f

docs(storybook): configure for ts

d457fdb

fix: update Marko and NativeTagInput

8d1c244

feat(tooltip-base): convert to ts

b50eb6a

feat(tooltip-overlay): convert to ts

2bcc399

fix(storybook): support declare keyword

253458b

feat(3d-viewer): convert to ts

1ff8dc7

feat(alert-dialog): convert to ts

4641947

feat(icon): convert to ts

40a2b4c

feat(svg): convert to ts

6ef2fa8

feat(badge): convert to ts

6708ba1

feat(breadcrumbs): convert to ts

035ec57

feat(button): convert to ts

bf14400

feat(calendar): convert to ts

dfb2e15

docs(storybook): convert .storybook to ts

cbc1165

feat(carousel): convert to ts

35dd3de

feat(checkbox): convert to ts

43a2cc4

feat(combobox): convert to ts

8a65782

feat(dialog): convert to ts

dbb0da4

LuLaValva added 7 commits December 7, 2023 11:20

chore(import-svg): swap comment

be73626

fix(ts): imports to .js files

9d32ffc

fix: remove .ts from flag defs

ddeedb0

fix(ts): mtc errors since rebase

c701ec7

fix(storybook): switch to named default exports

cff96e4

feat(ts): make types stricter and fix problems

c55fb19

feat(confirm-dialog): don't pass confirmCtaVariant to dialog-base

12a3635

agliga requested review from saiponnada, ianmcburnie, ArtBlue and LuLaValva December 14, 2023 01:34

fix(test): browser tests with ts

91b78ee

agliga force-pushed the floatingui branch from 6494a1a to 67100f4 Compare December 14, 2023 18:37

LuLaValva and others added 5 commits December 14, 2023 11:09

fix: browser tests

0f5dfed

fix(carousel): added delay to interacting state if carousel is moving

f42b573

fix(test): browser test edge cases

0bd538e

fix: remove console log

beb1a5d

feat(tooltip): swapped to use floatingui

3ef47b5

agliga force-pushed the floatingui branch from 67100f4 to 3ef47b5 Compare December 18, 2023 23:45

Merge branch '13.0.0' of https://github.com/eBay/ebayui-core into flo…

3602ea0

…atingui

agliga force-pushed the floatingui branch from 754a2e7 to 3602ea0 Compare December 19, 2023 20:53

agliga added 2 commits December 21, 2023 09:20

fix: text on different screen size

d23fe50

Merge branch '13.0.0' of https://github.com/eBay/ebayui-core into flo…

8b2bd3c

…atingui

LuLaValva approved these changes Dec 22, 2023

View reviewed changes

fix(tooltip): added old pointer positions and added positions as new

0d0147f

list

LuLaValva approved these changes Dec 22, 2023

View reviewed changes

src/components/components/ebay-tooltip-base/constants.ts Outdated Show resolved Hide resolved

fix: changed type to Placement for pointerStyles

be1c1c9

agliga merged commit f6ccce5 into 13.0.0 Dec 22, 2023
1 check failed

agliga deleted the floatingui branch December 22, 2023 22:57

LuLaValva pushed a commit that referenced this pull request Dec 23, 2023

feat(tooltip): swapped to use floatingui (#2037)

55c758f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tooltip): swapped to use floatingui #2037

feat(tooltip): swapped to use floatingui #2037

agliga commented Dec 14, 2023 •

edited

Loading

LuLaValva left a comment

LuLaValva left a comment

feat(tooltip): swapped to use floatingui #2037

feat(tooltip): swapped to use floatingui #2037

Conversation

agliga commented Dec 14, 2023 • edited Loading

Description

LuLaValva left a comment

Choose a reason for hiding this comment

LuLaValva left a comment

Choose a reason for hiding this comment

agliga commented Dec 14, 2023 •

edited

Loading