Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): imported flags from skin as components #2022

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat(flags): imported flags from skin as components #2022

merged 1 commit into from
Nov 20, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 14, 2023

Description

Imported flags into ebayui. Added as a new module.

References

#2007

Screenshots

Screenshot 2023-11-14 at 2 33 39 PM

@agliga agliga self-assigned this Nov 14, 2023
@agliga
Copy link
Contributor Author

agliga commented Nov 15, 2023

CI will fail until we prepublish skin

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run prettier on all of these .js and .json files, to keep them consistent with the rest of the source? This is potentially also something we can add to the import script

@agliga
Copy link
Contributor Author

agliga commented Nov 17, 2023

Should we run prettier on all of these .js and .json files, to keep them consistent with the rest of the source? This is potentially also something we can add to the import script

Every time we commit prettier is run on those files that were changed

Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuLaValva
Copy link
Member

Should we run prettier on all of these .js and .json files, to keep them consistent with the rest of the source? This is potentially also something we can add to the import script

Every time we commit prettier is run on those files that were changed

Ah I see, it's just the other icons that aren't formatted. We should format them in a separate PR.

@LuLaValva LuLaValva merged commit ee7e5a8 into 12.8.0 Nov 20, 2023
1 check failed
@LuLaValva LuLaValva deleted the flag branch November 20, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants