Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skeleton-loader): new component #2019

Merged
merged 9 commits into from
Dec 20, 2023

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Nov 9, 2023

Description

Added new skeleton loader component.

Note:
Snapshots for the tests are not being generated.

Context

#1976

Screenshots

image image

@saiponnada saiponnada self-assigned this Nov 9, 2023
src/components/ebay-skeleton-loader/index.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton-loader/index.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton-loader/index.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton-loader/index.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton/index.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton/index.marko Outdated Show resolved Hide resolved
Base automatically changed from 12.8.0 to master November 21, 2023 22:38
@saiponnada saiponnada changed the base branch from master to 13.0.0 December 7, 2023 18:13
@saiponnada saiponnada force-pushed the 1976-skeleton-loading-add-new-component branch from 4b58823 to 08c1c78 Compare December 7, 2023 18:24
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

src/components/ebay-skeleton/examples/withContent.marko Outdated Show resolved Hide resolved
src/components/ebay-skeleton/skeleton.stories.js Outdated Show resolved Hide resolved
@saiponnada saiponnada force-pushed the 1976-skeleton-loading-add-new-component branch from 65fbff1 to 994ac1e Compare December 20, 2023 01:48
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm overall
One comment. Otherwise its good to go imo

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for making all of the modifications

@saiponnada saiponnada merged commit a7652dd into 13.0.0 Dec 20, 2023
1 check failed
LuLaValva pushed a commit that referenced this pull request Dec 23, 2023
@agliga agliga deleted the 1976-skeleton-loading-add-new-component branch March 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants