Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): timezone bug #2013

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(calendar): timezone bug #2013

merged 3 commits into from
Nov 16, 2023

Conversation

LuLaValva
Copy link
Member

Description

Months were being shifted on the first day of the month in CET timezone, an additional UTC cast fixed the issue.

@LuLaValva LuLaValva requested review from ArtBlue and agliga November 1, 2023 16:03
@agliga
Copy link
Contributor

agliga commented Nov 1, 2023

Is this blocking? Do we need a patch or can it wait.
I think it looks fine otherwise

@LuLaValva
Copy link
Member Author

Do we need a patch or can it wait?

It depends how long we are waiting for, but I would like to get this in soon so I was thinking a patch was a good idea

@agliga
Copy link
Contributor

agliga commented Nov 2, 2023

Do we need a patch or can it wait?

It depends how long we are waiting for, but I would like to get this in soon so I was thinking a patch was a good idea

I understand. I think it's good to get it out soon
But our criteria for is only if the team is blocked completely and there is no workaround.
So verify if this is blocking their release or code. If not we can put it in 12.8.0

@LuLaValva
Copy link
Member Author

Do we need a patch or can it wait?

It depends how long we are waiting for, but I would like to get this in soon so I was thinking a patch was a good idea

I understand. I think it's good to get it out soon
But our criteria for is only if the team is blocked completely and there is no workaround.
So verify if this is blocking their release or code. If not we can put it in 12.8.0

This is blocking, and there is no workaround. The team in question is looking to start demos next week, but this effects all teams that use date textbox.

@agliga agliga changed the base branch from master to 12.8.0 November 9, 2023 15:56
@LuLaValva LuLaValva self-assigned this Nov 16, 2023
@LuLaValva LuLaValva merged commit 1454de8 into 12.8.0 Nov 16, 2023
1 check passed
@LuLaValva LuLaValva deleted the first-day-of-month-bug branch November 16, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants