Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): updated event names to improve DX #2012

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Oct 27, 2023

Description

Updated event handler names to improve consistency and DX across storybook stories.

  • Two-word events are refactored to use camel case e.g onClick
  • More than two-word events are refactored to use hyphen after first two words e.g onInput-change
  • I refactored all the stories except ebay-video

References

Fixes #1958

@saiponnada saiponnada self-assigned this Oct 27, 2023
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for doing this.

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for the storybook 7 pr to be merged first before merging this.

@saiponnada saiponnada force-pushed the 1958-fix-event-handlers-names-in-storybook branch from 882bdfc to 16b73c8 Compare November 9, 2023 02:38
@saiponnada
Copy link
Contributor Author

Added file calendar.stories.js that got accidentally deleted from PR #2010

@saiponnada saiponnada merged commit 2c2c8e6 into 12.8.0 Nov 9, 2023
1 check passed
@agliga agliga deleted the 1958-fix-event-handlers-names-in-storybook branch March 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants