chore: removed deprecations

.changeset/tidy-rockets-wonder.md

@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": major
+---
+
+chore: removed deprecated code

src/common/menu-utils/index.ts

@@ -10,7 +10,6 @@ export interface MenuItem extends Omit<Marko.HTML.Button, `on${string}`> {
 export interface BaseMenuInput {
     items?: Marko.AttrTag<MenuItem>;
     type?: string;
-    separator?: Marko.AttrTag<{}>;
 }
 
 export interface MenuState {
@@ -55,8 +54,8 @@ export class MenuUtils<
     }
 
     getInputState(input: Input) {
-        /* 
-            ebay-menu uses separators and we need to exclude these 
+        /*
+            ebay-menu uses separators and we need to exclude these
             from items to pass correct indexes to state
             Any other component that doesn't have separator should pass through
         */

src/components/ebay-fake-menu-button/component.ts

@@ -27,7 +27,6 @@ interface FakeMenuButtonInput extends Omit<Marko.HTML.Span, `on${string}`> {
     reverse?: boolean;
     "fix-width"?: boolean;
     items?: Marko.AttrTag<FakeMenuItem>;
-    separator?: Marko.AttrTag<{}>;
     "collapse-on-select"?: boolean;
     "on-expand"?: (event: MenuEvent) => void;
     "on-collapse"?: (event: MenuEvent) => void;

src/components/ebay-fake-menu-button/examples/separator.marko

@@ -1,7 +1,7 @@
 <ebay-fake-menu-button text="eBay Menu separator">
     <@item href="#">item 1</@item>
     <@item href="#">item 2</@item>
-    <@separator/>
+    <@item separator/>
     <@item href="#">item 3</@item>
     <@item href="#">item 4</@item>
     <@item href="#">item 5</@item>

src/components/ebay-fake-menu-button/marko-tag.json

@@ -1,6 +1,5 @@
 {
     "template": "./index.marko",
-    "transformer": "../../common/transformers/menu-separator",
     "@*": {
         "targetProperty": null,
         "type": "expression"
@@ -49,11 +48,5 @@
         "@class": "string",
         "@style": "string"
     },
-    "@separator <separator>[]": {
-        "@html-attributes": "expression",
-        "@class": "string",
-        "@style": "string",
-        "@separator": "boolean"
-    },
     "description": "[view documentation](https://ebay.github.io/ebayui-core/?path=/story/buttons-ebay-fake-menu-button)"
 }

src/components/ebay-fake-menu/component.ts

@@ -25,7 +25,6 @@ interface FakeMenuInput
     extends BaseMenuInput,
         Omit<Marko.HTML.Span, `on${string}`> {
     items?: Marko.AttrTag<Item>;
-    separator?: Marko.AttrTag<Separator>;
     "class-prefix"?: string;
     reverse?: boolean;
     "fix-width"?: boolean;

src/components/ebay-fake-menu/examples/separator.marko

@@ -1,7 +1,7 @@
 <ebay-fake-menu>
     <@item href="#">item 1 that has very long text</@item>
     <@item href="#">item 2</@item>
-    <@separator/>
+    <@item separator/>
     <@item href="#">item 3</@item>
     <@item href="#">item 4</@item>
     <@item href="#">item 5</@item>

src/components/ebay-fake-menu/marko-tag.json

@@ -4,7 +4,6 @@
         "type": "expression"
     },
     "template": "./index.marko",
-    "transformer": "../../common/transformers/menu-separator",
     "@html-attributes": "expression",
     "@class": "string",
     "@style": "string",
@@ -27,11 +26,5 @@
         "@badge-aria-label": "string",
         "@separator": "boolean"
     },
-    "@separator <separator>[]": {
-        "@html-attributes": "expression",
-        "@class": "string",
-        "@style": "string",
-        "@separator": "boolean"
-    },
     "description": "[view documentation](https://ebay.github.io/ebayui-core/?path=/story/building-blocks-ebay-fake-menu)"
 }

src/components/ebay-infotip/test/__snapshots__/test.server.js.snap

@@ -338,11 +338,6 @@ exports[`infotip modal > renders default 1`] = `
     <div
       class="lightbox-dialog__window lightbox-dialog__window--animate"
     >
-      <button
-        aria-label="Maximize Lightbox Dialog"
-        class="lightbox-dialog__handle"
-        type="button"
-      />
       <div
         class="lightbox-dialog__header"
       >

src/components/ebay-lightbox-dialog/examples/default.marko

@@ -35,8 +35,6 @@ class {
     open=state.open
     on-close("closeDialog")
     on-open("emit", "open")
-    on-expanded("emit", "expanded")
-    on-collapsed("emit", "collapsed")
     ...dialogBaseInput
 >
     <if(header && header.renderBody)>

src/components/ebay-lightbox-dialog/examples/focus.marko

@@ -4,8 +4,6 @@
     open=state.open
     on-close('closeDialog')
     on-open("emit", "open")
-    on-expanded("emit", "expanded")
-    on-collapsed("emit", "collapsed")
     ...input
 >
     <@header>Heading</@header>

src/components/ebay-lightbox-dialog/examples/scrolling.marko

@@ -22,8 +22,6 @@ class {
     open=state.open
     on-close("closeDialog")
     on-open("emit", "open")
-    on-expanded("emit", "expanded")
-    on-collapsed("emit", "collapsed")
     ...input
 >
     <@header>Heading</@header>

src/components/ebay-lightbox-dialog/examples/with-footer.marko

@@ -3,8 +3,6 @@
     open=state.open
     on-close("closeDialog")
     on-open("emit", "open")
-    on-expanded("emit", "expanded")
-    on-collapsed("emit", "collapsed")
     ...input
 >
     <@header>Heading</@header>

src/components/ebay-lightbox-dialog/examples/with-prev-button.marko

@@ -4,8 +4,6 @@
     on-close("closeDialog")
     on-open("emit", "open")
     on-prevButtonClick("emit", "prev-button-click")
-    on-expanded("emit", "expanded")
-    on-collapsed("emit", "collapsed")
     ...input
 >
     <@header>Heading</@header>