diff --git a/.changeset/good-jobs-cheat.md b/.changeset/good-jobs-cheat.md deleted file mode 100644 index 5912757b7..000000000 --- a/.changeset/good-jobs-cheat.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@ebay/ebayui-core": patch ---- - -fix(dialog): added request animation frame before running keyboardTrap diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e8d0ff74..693b673a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # eBayUI-Core Changelog +## 14.6.6 + +### Patch Changes + +- [#2377](https://github.com/eBay/ebayui-core/pull/2377) [`06d6ae6`](https://github.com/eBay/ebayui-core/commit/06d6ae60cb3dff261c208666a1f985bcdd2f8eb4) Thanks [@agliga](https://github.com/agliga)! - fix(dialog): added request animation frame before running keyboardTrap + ## 14.6.5 ### Patch Changes diff --git a/package-lock.json b/package-lock.json index 4d4c18021..48c5ce385 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ebay/ebayui-core", - "version": "14.6.5", + "version": "14.6.6", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@ebay/ebayui-core", - "version": "14.6.5", + "version": "14.6.6", "license": "MIT", "dependencies": { "@floating-ui/dom": "^1.6.12", diff --git a/package.json b/package.json index 08fd5e264..408392f14 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ebay/ebayui-core", - "version": "14.6.5", + "version": "14.6.6", "description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.", "keywords": [ "marko-components" diff --git a/src/components/components/ebay-dialog-base/component.ts b/src/components/components/ebay-dialog-base/component.ts index 02563a943..911628682 100644 --- a/src/components/components/ebay-dialog-base/component.ts +++ b/src/components/components/ebay-dialog-base/component.ts @@ -247,7 +247,9 @@ class DialogBase extends Marko.Component { screenReaderTrap.trap(this.el, { useHiddenProperty }); if (!useHiddenProperty) { // Adding request animation frame because focusables will return that all elements are not visible since dialog is still animating. - requestAnimationFrame(() => keyboardTrap.trap(this.windowEl)); + requestAnimationFrame(() => + keyboardTrap.trap(this.windowEl), + ); } } };