Skip to content

Commit

Permalink
ci: release (#2378)
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] authored Jan 10, 2025
1 parent 06d6ae6 commit 8131c21
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
5 changes: 0 additions & 5 deletions .changeset/good-jobs-cheat.md

This file was deleted.

6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# eBayUI-Core Changelog

## 14.6.6

### Patch Changes

- [#2377](https://github.com/eBay/ebayui-core/pull/2377) [`06d6ae6`](https://github.com/eBay/ebayui-core/commit/06d6ae60cb3dff261c208666a1f985bcdd2f8eb4) Thanks [@agliga](https://github.com/agliga)! - fix(dialog): added request animation frame before running keyboardTrap

## 14.6.5

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ebay/ebayui-core",
"version": "14.6.5",
"version": "14.6.6",
"description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
"keywords": [
"marko-components"
Expand Down
4 changes: 3 additions & 1 deletion src/components/components/ebay-dialog-base/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ class DialogBase extends Marko.Component<Input, State> {
screenReaderTrap.trap(this.el, { useHiddenProperty });
if (!useHiddenProperty) {
// Adding request animation frame because focusables will return that all elements are not visible since dialog is still animating.
requestAnimationFrame(() => keyboardTrap.trap(this.windowEl));
requestAnimationFrame(() =>
keyboardTrap.trap(this.windowEl),
);
}
}
};
Expand Down

0 comments on commit 8131c21

Please sign in to comment.