Skip to content

Commit

Permalink
chore: upgrade marko & mtc, fix type errors (#2376)
Browse files Browse the repository at this point in the history
LuLaValva authored and agliga committed Jan 16, 2025

Verified

This commit was signed with the committer’s verified signature.
agliga Andrew Gliga
1 parent 985ec4f commit 59357e6
Showing 7 changed files with 122 additions and 125 deletions.
5 changes: 5 additions & 0 deletions .changeset/thirty-walls-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

Upgrade dependencies
204 changes: 95 additions & 109 deletions package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -101,10 +101,10 @@
"@commitlint/config-conventional": "^19",
"@ebay/browserslist-config": "^2.10.0",
"@ebay/skin": "~18.6.0",
"@marko/compiler": "^5.37.23",
"@marko/compiler": "^5.39.10",
"@marko/prettyprint": "^3.0.1",
"@marko/testing-library": "^6",
"@marko/type-check": "^1.2.4",
"@marko/type-check": "^1.3.12",
"@marko/vite": "^4.1.20",
"@storybook/addon-a11y": "^8.3.6",
"@storybook/addon-docs": "^8.3.6",
@@ -132,7 +132,7 @@
"libphonenumber-js": "^1.11.17",
"lint-staged": "^15.2.11",
"lintspaces-cli": "^1.0.0",
"marko": "^5.35.32",
"marko": "^5.37.10",
"playwright": "^1.49.1",
"postcss-less": "^6.0.0",
"prettier": "^3.4.2",
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ebay-breadcrumbs a11yHeadingText="Page navigation">
<@item href="http://www.ebay.com/" navsrc="{}" _sp="p2345.m909.l34">eBay</@item>
<@item href="https://www.ebay.com/rpp/cell-phone-pda" navsrc="{}" _sp="p2345.m909.l34">Cell Phones, Smart Watches & Accessories</@item>
<@item href="https://www.ebay.com/b/Smart-Watch-Accessories/182064/bn_16565905" navsrc="{}" _sp="p2345.m909.l34">Smart Watch Accessories</@item>
<@item href="http://www.ebay.com/">eBay</@item>
<@item href="https://www.ebay.com/rpp/cell-phone-pda">Cell Phones, Smart Watches & Accessories</@item>
<@item href="https://www.ebay.com/b/Smart-Watch-Accessories/182064/bn_16565905">Smart Watch Accessories</@item>
<@item>Smart Watch Bands</@item>
</ebay-breadcrumbs>
4 changes: 2 additions & 2 deletions src/components/ebay-progress-stepper/index.marko
Original file line number Diff line number Diff line change
@@ -5,9 +5,9 @@ import type { AttrString } from 'marko/tags-html';
export interface Step extends Omit<Marko.Input<"div">, `on${string}` | "title"> {
current?: boolean;
a11yText?: string;
title?: Omit<Marko.Input<"h4">, `on${string}`> & {
title?: Marko.AttrTag<Omit<Marko.Input<"h4">, `on${string}`> & {
as?: keyof Marko.NativeTags;
}
}>
}
static interface ProgressStepperInput extends Omit<Marko.Input<"div">, `on${string}`> {
2 changes: 1 addition & 1 deletion src/components/ebay-segmented-buttons/index.marko
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ export interface SegmentedButtonsEvent {

export interface SegmentedButton extends Omit<Marko.Input<"button">, `on${string}`> {
selected?: boolean;
icon?: Marko.Renderable;
icon?: Marko.AttrTag<{ renderBody: Marko.Body }>;
}

static interface SegmentedButtonsInput extends Omit<Marko.Input<"div">, `on${string}`> {
20 changes: 13 additions & 7 deletions src/components/ebay-table/component.ts
Original file line number Diff line number Diff line change
@@ -4,25 +4,30 @@ import { CheckboxEvent } from "../ebay-checkbox/component-browser";

export type TableSort = "asc" | "desc" | "none";
export interface TableHeader extends Omit<Marko.Input<"th">, `on${string}`> {
columnType?: "normal" | "numeric" | "row-header" | "layout" | "icon-action";
"column-type"?:
| "normal"
| "numeric"
| "row-header"
| "layout"
| "icon-action";
name?: string;
sort?: TableSort | boolean;
href?: AttrString;
renderBody: Marko.Body;
}

export interface TableCell
extends Omit<Marko.Input<"td"> & Marko.Input<"th">, `on${string}`> {
renderBody: Marko.Body;
}
extends Omit<Marko.Input<"td"> & Marko.Input<"th">, `on${string}`> {}

export interface TableRow extends Omit<Marko.Input<"tr">, `on${string}`> {
name?: string;
selected?: boolean;
cell: Marko.AttrTag<TableCell>;
cell?: Marko.AttrTag<TableCell>;
}
export interface TableInput extends Omit<Marko.Input<"div">, `on${string}`> {
header: Marko.AttrTag<TableHeader>;
header: Marko.AttrTag<WithNormalizedProps<TableHeader>>;
mode?: "none" | "selection";
allSelected?: AttrTriState;
"all-selected"?: AttrTriState;
row?: Marko.AttrTag<TableRow>;
density?: "compact" | "relaxed" | "none";
"a11y-select-all-text"?: string;
@@ -33,6 +38,7 @@ export interface TableInput extends Omit<Marko.Input<"div">, `on${string}`> {
}) => void;
"on-sort"?: (event: { sorted: Record<string, TableSort> }) => void;
}

export interface Input extends WithNormalizedProps<TableInput> {}

interface State {

0 comments on commit 59357e6

Please sign in to comment.