refactor(skeleton): added default type

eBay · Nov 14, 2023 · 4b58823 · 4b58823
1 parent 99f12ba
commit 4b58823
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/components/ebay-skeleton/index.marko b/src/components/ebay-skeleton/index.marko
@@ -12,8 +12,8 @@ static var validTypes = ["avatar", "button", "text", "form", "image", "tile"];
 static var validSizes = ["large", "small"];
 static var validTypeSizes = ["button", "text", "tile"];
 $ var size = validSizes.includes(input.size) ? input.size : "default";
-$ var type = validTypes.includes(input.type) ? input.type : null;
-$ var typeClass = type && `skeleton-${type}`;
+$ var type = validTypes.includes(input.type) ? input.type : "form";
+$ var typeClass = `skeleton-${type}`;
 $ var skeletonClass = (
     validTypeSizes.includes(input.type) &&
     (size !== "default"

diff --git a/src/components/ebay-skeleton/skeleton.stories.js b/src/components/ebay-skeleton/skeleton.stories.js
@@ -38,6 +38,11 @@ export default {
         type: {
             control: { type: "select" },
             options: ["avatar", "button", "text", "form", "image", "tile"],
+            table: {
+                defaultValue: {
+                    summary: "form",
+                },
+            },
             description: "Type of the component to render.",
         },
         size: {
@@ -76,8 +81,6 @@ export default {
 export const Default = Template.bind({});
 Default.args = {
     style: "width: 220px",
-    type: "button",
-    size: "small",
 };
 Default.parameters = {
     docs: {