feat(table): update TableHeader interface and examples to use WithNor…

…malizedProps
eBay · Jan 2, 2025 · 21f9d1b · 21f9d1b
1 parent b767d14
commit 21f9d1b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/components/ebay-table/component.ts b/src/components/ebay-table/component.ts
@@ -3,11 +3,9 @@ import { WithNormalizedProps } from "../../global";
 import { CheckboxEvent } from "../ebay-checkbox/component-browser";
 
 export type TableSort = "asc" | "desc" | "none";
-interface TableHeaderProps {
+export interface TableHeader extends Omit<Marko.Input<"th">, `on${string}`> {
     "column-type"?: "normal" | "numeric" | "layout" | "icon-action";
     "row-header"?: boolean;
-}
-export interface TableHeader extends WithNormalizedProps<TableHeaderProps>, Omit<Marko.Input<"th">, `on${string}`> {
     name?: string;
     sort?: TableSort | boolean;
     href?: AttrString;
@@ -24,7 +22,7 @@ export interface TableRow extends Omit<Marko.Input<"tr">, `on${string}`> {
     cell: Marko.AttrTag<TableCell>;
 }
 export interface TableInput extends Omit<Marko.Input<"div">, `on${string}`> {
-    header: Marko.AttrTag<TableHeader>;
+    header: Marko.AttrTag<WithNormalizedProps<TableHeader>>;
     mode?: "none" | "selection";
     allSelected?: AttrTriState;
     row?: Marko.AttrTag<TableRow>;

diff --git a/src/components/ebay-table/examples/default.marko b/src/components/ebay-table/examples/default.marko
@@ -6,17 +6,17 @@ import data from "./data.json";
     </@header>
     <@header>Item</@header>
     <@header>Status</@header>
-    <@header column-type="numeric">
+    <@header column-type="numeric" as const>
         List Price
     </@header>
-    <@header column-type="numeric">
+    <@header column-type="numeric" as const>
         Quantity Available
     </@header>
     <@header>Orders</@header>
-    <@header column-type="numeric">
+    <@header column-type="numeric" as const>
         Watchers
     </@header>
-    <@header column-type="numeric">
+    <@header column-type="numeric" as const>
         Protection
     </@header>
     <@header>Shipping</@header>