Persistent Caching of available Implementations (Dose Engines, Stf Generators, etc.) #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nario models, bio models, dose engines)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #817 +/- ##
==========================================
+ Coverage 51.47% 51.53% +0.05%
==========================================
Files 598 598
Lines 37306 37340 +34
==========================================
+ Hits 19204 19242 +38
+ Misses 18102 18098 -4 ☔ View full report in Codecov by Sentry. |
|
amitantony
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes involve the introduction of persistent variables to cache the available implementations for DoseEngines, StfGenerators, ScenarioModels and BioModels to avoid slow response when operating in large paths. Further, we allow suppression of the warning message when the default generator is used.
Caching improvements:
matRad/bioModels/matRad_BiologicalModel.m: Added persistent variablesmetaBioModelsandlastOptionalPathsto cache the results ofmatRad_findSubclassesand avoid redundant computations.matRad/doseCalc/+DoseEngines/@matRad_DoseEngineBase/getAvailableEngines.m: Introduced persistent variablesallAvailableDoseEnginesandlastOptionalPathsto cache the list of available dose engines.matRad/scenarios/matRad_ScenarioModel.m: Implemented persistent variablesmetaScenarioModelsandlastOptionalPathsto store the results ofmatRad_findSubclassesfor scenario models.matRad/steering/matRad_StfGeneratorBase.m: Added persistent variablesallAvailableStfGeneratorsandlastOptionalPathsto cache the available STF generators.Functionality enhancement:
matRad/steering/matRad_StfGeneratorBase.m: Modified thegetGeneratorFromPlnmethod to include a new parameterwarnDefaultthat controls whether a warning message is displayed when the default STF generator is used. [1] [2]