Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More plot axis labels fixes #694

Closed
wants to merge 3 commits into from

Conversation

ferdymercury
Copy link
Contributor

I make a separate PR as this changes a bit the plotting conventions

@ferdymercury
Copy link
Contributor Author

Also, ct.x and ct.y could be included, but I am not sure how you want to deal with the tick labels then.

@wahln
Copy link
Contributor

wahln commented Feb 2, 2024

This is a bit more tricky, because there's a problem in matRad's internal coordinates which we didn't dare to touch yet.
ct.x/y/z should corresponds to a world coordinates in the coordinate system (which matRad chooses rather simply if ct.x/y/z are not defined).
However, the isocenter coordinates are relative to the image origin, so there usually is a translation between those coordinate systems.

So it is not absolutely cut and dry what should be shown here. The image system where you get the isocenter correctly plotted or the ct.x/y/z world?

Have to think about that and maybe dare change it globally so the coordinates are completely consistent.

@amitantony amitantony closed this Mar 27, 2024
@amitantony
Copy link
Contributor

This PR is now redundant with the new PR #704 which should change set the whole front facing coordinate system to the world coordinate system

@ferdymercury ferdymercury deleted the plotlabels2 branch March 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants