Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create the eth abi decoding #697

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: create the eth abi decoding #697

merged 1 commit into from
Jul 3, 2023

Conversation

albertolerda
Copy link
Member

No description provided.

@jaromil
Copy link
Member

jaromil commented Jul 2, 2023

Related to issue #681 we need to see if used is appropriate, perhaps better use stored?

@albertolerda
Copy link
Member Author

It is actually quite different, the keyword "using", in this case, is used like in the statements compose the secret using '', create the ethereum abi encoding of '' using '', create the jws signature using the ecdh signature in '', .... (it is not a verb, just specify a variable)

In the other PR, the keyword use is specific to ethereum and tells how to fill the field data/value of the ethereum transaction object

@andrea-dintino
Copy link
Member

@jaromil we use the keyword 'using' in 7 statements already (include scenario 'secshare'):

https://gyazo.com/a481c21abcae97030f88a8b5391e7c6f

@jaromil
Copy link
Member

jaromil commented Jul 3, 2023

ACK! thanks

@jaromil jaromil merged commit 3c8df4b into master Jul 3, 2023
36 checks passed
@jaromil jaromil deleted the feat/abi-decode branch July 3, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants