ForeignKey related_name reverse lookup raises AttributeError

[edimedia]

Problem

Get all user's scopes

user_scopes = Scope.query.filter(permission_scopes__user__id=user_id) # AttributeError : id

Check the filter lookup

permission_scopes ==> related_name
user ==> ForeignKey
id ==> a UUIDField

BUT this works correctly

user = await User.query.get(id=user_id)
user_scopes = await Scope.query.filter(permission_scopes__user=user) # We have the expected result with the User object

Models

> User model

class User(Model):
    """User model"""
    id: UUID = fields.UUIDField(primary_key=True, default=uuid.uuid4)
    username: str = fields.CharField(max_length=75)

> Scope model

class Scope(Model):
    """User Permission Scope model"""
    name: str = fields.CharField(max_length=75)
    codename: str = fields.CharField(max_length=12, index=True, unique=True)
    default: bool = fields.BooleanField(default=False)
    default_permissions = fields.CharField(max_length=6, default='R')

> Permission model

class Permission(Model):
    """User Permission model"""
    user: UUID = fields.ForeignKey(
        UserModel,
        related_name="permissions",
        on_delete=CASCADE
    )
    scope: UUID = fields.ForeignKey(
        PermissionScope,
        related_name="permission_scopes",
        on_delete=CASCADE
    )
    assigned_at: datetime = fields.DateTimeField(auto_now_add=True)
    ....

The exception is raised at select_from.c.id == getattr(table.c, lookup_field) by select_from.c.id

edgy/edgy/core/db/querysets/base.py

Line 244 in 791f604

select_from = sqlalchemy.sql.join( # type: ignore

When i changed the code to this, the first query works as expected

try:
     select_from = sqlalchemy.sql.join(  # type: ignore
             select_from,
             table,
             select_from.c.id == getattr(table.c, lookup_field),
      )
 except AttributeError as e:
      pass

[tarsil]

@devkral did we change the internal check here?

[edimedia]

try:
     select_from = sqlalchemy.sql.join(  # type: ignore
             select_from,
             table,
             select_from.c.id == getattr(table.c, lookup_field),
      )
 except AttributeError as e:
      pass

Correction, this also does not work as expected.

[edimedia]

Thanks too.

I'm working with Edgy, and i'm waiting for this #101

[tarsil]

How did you find it so far? We have a big release coming out soon. We are just aligning some internals

[edimedia]

I really like it; it offers the same comfort as Django ORM, especially if you come from Django.

Among the options I had, I chose this one.

[tarsil]

That was the purpose of the feeling. I'm glad you enjoy. Let us address these internals and then we should be able to release

[edimedia]

Thank you! I appreciate your hard work on this. I'm looking forward to the release and the improvements it will bring.

[tarsil]

@devkral lets see what happened here as well, we might have introduced a regression with the internal refactoring.

[devkral]

can you provide a full example?

[devkral]

I get the issue:
.id is used. This is hardcoded

[tarsil]

Not hardcoded itself. We were in the past using the 'id' as the official primary key and that was always in the model, now we have updated that.

[devkral]

you had a setting for this and this part didn't used it so I missed it. So it was hardcoded.
I fixed the bug (I think so) and removed the setting (it is obsolete)

[tarsil]

Let the CI run

[devkral]

should be fixed now. Please try again

[tarsil]

@devkral @edimedia with this big new release of 0.12.0 of Edgy, you should see all the good things and improvements added by @devkral