Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect required flag on properties #19

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: respect required flag on properties #19

merged 2 commits into from
Dec 19, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 19, 2024

No description provided.

@zshipko zshipko requested a review from G4Vi December 19, 2024 18:54
@zshipko zshipko requested a review from bhelx as a code owner December 19, 2024 18:54
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are there any cases you're aware of that need additional work?

@zshipko
Copy link
Contributor Author

zshipko commented Dec 19, 2024

Not that I can think of - but I think there is still some stuff adjacent this but related to extism/python-pdk#37 that might need looking into. Are you planning on looking into that issue too?

@G4Vi
Copy link
Contributor

G4Vi commented Dec 19, 2024

extism/python-pdk#37 that might need looking into. Are you planning on looking into that issue too?

I will look into that.

@zshipko zshipko merged commit 475a678 into main Dec 19, 2024
1 check passed
@zshipko zshipko deleted the fix-required branch December 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants