Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Typespec for Binary URL Input on generate_oauth_url/1 #96

Closed
ccarvalho-eng opened this issue May 22, 2023 · 4 comments · Fixed by #97
Closed

Missing Typespec for Binary URL Input on generate_oauth_url/1 #96

ccarvalho-eng opened this issue May 22, 2023 · 4 comments · Fixed by #97
Labels
chore documentation Improvements or additions to documentation please-test T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. technical user-feedback

Comments

@ccarvalho-eng
Copy link
Contributor

ccarvalho-eng commented May 22, 2023 •
edited
Loading

I've noticed an issue in the following section of code: https://github.com/dwyl/elixir-auth-google/blob/main/lib/elixir_auth_google.ex#L81. It appears that a typespec hasn't been defined for scenarios where a binary URL is passed. This absence is causing Dialyzer contract violations for those who pass a URL as a binary string instead of utilizing %Plug.Conn{} or the Endpoint.url/0 function.
@ccarvalho-eng ccarvalho-eng changed the title Missing Typespec for Binary URL Input for generate_oauth_url/1 Missing Typespec for Binary URL Input on generate_oauth_url/1 May 22, 2023
@nelsonic
Copy link
Member

Hi @wood-archer, thanks for reporting this oversight. 👌
If you have time to add, please open a PR. 🙏

@nelsonic nelsonic added documentation Improvements or additions to documentation user-feedback chore technical T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels May 22, 2023
@ccarvalho-eng ccarvalho-eng mentioned this issue May 22, 2023
Merged
nelsonic added a commit that referenced this issue May 22, 2023
@nelsonic
bump version 1.6.8 -> 1.6.9 to release typespec see: #97 #96
9bf07ac
@nelsonic
Copy link
Member

Package published to https://hex.pm/packages/elixir_auth_google/1.6.9 📦
Please test. 🙏

@ccarvalho-eng
Copy link
Contributor Author

Works like a charm! We thanks!

@nelsonic
Copy link
Member

Thanks for confirming @wood-archer 👌 and thanks again for the swift and helpful contribution. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore documentation Improvements or additions to documentation please-test T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. technical user-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds missing typespec to generate_oauth_url/1 ccarvalho-eng/elixir-auth-google
2 participants
@nelsonic @ccarvalho-eng