Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Overriding scopes by enviromnent variables does not work properly on multiple scopes #92

Closed
LuchoTurtle opened this issue Apr 17, 2023 · 1 comment · Fixed by #93
Assignees
Labels
bug Something isn't working chore documentation Improvements or additions to documentation priority-1

Comments

@LuchoTurtle
Copy link
Member

I tried overriding the scopes by having an .env file and running source .env on my terminal and I had something like this:

export GOOGLE_SCOPE=profile email calendar

However, when I inspected the network request calls, I noticed that only profile was passed.
When I reset my project and override by adding the configuration in config/config.ex, it worked as expected.

This means that the section in https://github.com/dwyl/elixir-auth-google#optional-scopes is wrong and needs some correction.
I didn't test it but maybe export GOOGLE_SCOPE="profile email calendar" works instead.

@LuchoTurtle LuchoTurtle added bug Something isn't working documentation Improvements or additions to documentation chore labels Apr 17, 2023
@LuchoTurtle LuchoTurtle self-assigned this Apr 17, 2023
@LuchoTurtle LuchoTurtle moved this to 🔖 Ready for Development in dwyl app kanban Apr 17, 2023
@nelsonic
Copy link
Member

Indeed, the quotes are needed. 👍

LuchoTurtle added a commit that referenced this issue Apr 26, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready for Development to ✅ Done in dwyl app kanban Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore documentation Improvements or additions to documentation priority-1
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants