-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the callback url manually when autodetection is incorrect. #83
Comments
Hi @wmealing, thanks for opening this issue to give your feedback. The If you'd like to help us understand the challenge you're facing, |
I'll work on trying to figure out the difference, I'm not super competent at web programming. This will take a little while. I checked the other PR's and thats a lot of work to help debug this issue. Will respond here when I figure out what i've done wrong. |
@wmealing we're all learning. doubt you've done anything "wrong". 💭 |
I believe that I had the configuration of "url" incorrect in my config/prod.exs
When I changed this, it now generates the correct redirect_uri. Thank you for taking the time to steer me in the right direction. |
@wmealing thanks for confirming. Glad you figured it out. 👌 |
Gday,
I have found a case where the auto generation of the callback url fails. If you're running phoenix on port 80 behind a proxy (like on fly.io) the auto generated callback url defaults to http, even though fly.io automatically proxies the node to https.
When this is the case, the default callback_uri ends up being incorrect and not matching the expected protocol/name that google expects.
I did not find a good way around this, other than hacking the code to allow an environment / config variable to set the protocol and server. Is there a better way that you recommend ?
If you're interested I can perhaps do a first draft of a patch and submit, however I thought i'd talk about the problem before going that route.
Thanks for this project.
The text was updated successfully, but these errors were encountered: