Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation warning about Elixir version when using 1.13 #57

Closed
sax opened this issue Jan 25, 2022 · 4 comments
Closed

Compilation warning about Elixir version when using 1.13 #57

sax opened this issue Jan 25, 2022 · 4 comments
Labels

Comments

@sax
Copy link

sax commented Jan 25, 2022

I noticed that the elixir version pinned in mix.exs is ~> 1.12.3. The project seems compile fine on 1.13, but issues a compiler warning.

@nelsonic nelsonic added chore help wanted Extra attention is needed T25m technical labels Jan 25, 2022
@nelsonic
Copy link
Member

@sax thanks for opening this issue to inform us. 👍

@nelsonic
Copy link
Member

The action on this issue is to either "relax" the requirements to avoid the warning.
Or explicitly update the version to 1.13 ... 💭

Phoenix has: https://github.com/phoenixframework/phoenix/blob/de142f35e13e0e8661fa5d2eb7fa36f13b3d1158/mix.exs#L17

@elixir_requirement "~> 1.9"

...

elixir: @elixir_requirement,

Wonder if this will do the trick. 🤔

@sax
Copy link
Author

sax commented Apr 30, 2022

Last I checked there weren't any specific function calls that ~> 1.9 wouldn't support.

@nelsonic
Copy link
Member

nelsonic commented Sep 2, 2022

Closing as resolved. (We haven't seen this warning in practice on any of our apps using the package). 👍
Please comment / re-open if you are still facing the issue. Thanks. 🙏

@nelsonic nelsonic closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants