Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update httpoison to 1.7.0 to avoid TLS Error #38

Closed
3 tasks done
nelsonic opened this issue Jul 17, 2020 · 1 comment · Fixed by #39
Closed
3 tasks done

Update httpoison to 1.7.0 to avoid TLS Error #38

nelsonic opened this issue Jul 17, 2020 · 1 comment · Fixed by #39
Labels
chore T25m technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Jul 17, 2020 •
edited
Loading

As noted in dwyl/auth#83 and dwyl/elixir-auth-google-demo#3 we are getting a TLS error when using Erlang v23:

auth-cowboy-error

https://elixirforum.com/t/erlang-v-23-0-and-httpoison-error/31615

The fix is pretty simple:

mix deps.update httpoison
  • make the update
  • create PR
  • publish new version 1.2.0 > 1.3.0
nelsonic added a commit that referenced this issue Jul 17, 2020
@nelsonic
update httpoison to latest version fixes TLS error issue #38
56d03b1
nelsonic added a commit that referenced this issue Jul 17, 2020
@nelsonic
update version of package in README.md to 1.3.0 for #38
9a6cef9
@nelsonic nelsonic mentioned this issue Jul 17, 2020
Merged
1 task
@nelsonic
Copy link
Member Author

Travis-CI build https://travis-ci.com/github/dwyl/elixir-auth-google/builds/176015692
fails because of unmatched Elixir/OTP version:
image

Updating now.

nelsonic added a commit that referenced this issue Jul 17, 2020
@nelsonic
update elixir to 1.10 and OTP to 23.0 #38 (comment)
9219d78
iteles added a commit that referenced this issue Jul 17, 2020
@iteles
Merge pull request #39 from dwyl/update-httpoison-to-fix-tls-error-is…
84aa3ae 
…sue-#38

Update httpoison to fix TLS error issue #38
nelsonic added a commit to dwyl/elixir-auth-google-demo that referenced this issue Jul 17, 2020
@nelsonic
use elixir_auth_google v1.3.0 with latest httpoison 1.7 see: dwyl/eli…
1bc3275 
…xir-auth-google#38
@nelsonic nelsonic mentioned this issue Jul 17, 2020
Merged
1 task
nelsonic added a commit to dwyl/elixir-auth-github that referenced this issue Jul 17, 2020
@nelsonic
update httpoison to latest version to avoid TLS error see: dwyl/elixi…
d769786 
…r-auth-google#38
@nelsonic nelsonic mentioned this issue Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore T25m technical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update httpoison to fix TLS error issue #38 dwyl/elixir-auth-google
1 participant
@nelsonic