protocol String.Chars not implemented for %{"email_verified" => "false"} of type Map

[nelsonic]

Part of documenting #10 this package is attempting to create an app that uses the package from scratch. I am creating the absolute minimum steps example in: https://github.com/dwyl/auth-demo

When I attempt to access the "email_verified" property of the profile (returned by Google)
in a template e.g:

<section class="phx-hero">
  <%= @profile.email_verified != "true" do %>

    <h1>Welcome to Awesome App!</h1>
    <p>To get started, login to your Google Account: <p>
    <a href="<%= @oauth_google_url %>">
      <img src="https://i.imgur.com/Kagbzkq.png" alt="Sign in with Google" />
    </a>
  <% else %>
    <h1> Welcome <%= @profile["given_name"] %> </h1>
  <% end %>
</section>

I see the following error:

protocol String.Chars not implemented for %{"email_verified" => "false"} of type Map

This is very unfriendly to end users (the beginners who are attempting to consume the package).
This is partly Elixir being unfriendly and partly our fault for not making the profile map easier to use.

I feel we could improve this by transforming the keys of the profile map from strings to atoms.
https://stackoverflow.com/questions/31990134/convert-map-keys-from-strings-to-atoms-in-elixir

Specifically in the parse_body_response currently:

elixir-auth-google/lib/elixir_auth_google.ex

Lines 38 to 45 in 687fba5

	defp parse_body_response({:ok, response}) do
	body = Map.get(response, :body)
	if body == nil do
	{:error, :no_body}
	else
	Poison.decode(body)
	end
	end

Could be:

  def parse_body_response({:ok, response}) do
    body = Map.get(response, :body)
    if body == nil do
      {:error, :no_body}
    else # make keys of map atoms for easier access in templates
      {:ok, str_key_map} = Poison.decode(body)
      atom_key_map = for {key, val} <- str_key_map, into: %{},
        do: {String.to_atom(key), val}
      {:ok, atom_key_map}
    end # https://stackoverflow.com/questions/31990134
  end

So that instead of returning a Map where they keys are strings:

%{
  "email" => "nelson@gmail.com",
  "email_verified" => true,
  "family_name" => "Correia",
  "given_name" => "Nelson",
  "locale" => "en",
  "name" => "Nelson Correia",
  "picture" => "https://lh3.googleusercontent.com/a-/AAuE7mApnYb260YC1JY7",
  "sub" => "940732358705212133793"
}

The parse_body_response would return a Map where the keys are atoms:

%{
  email: "nelson@gmail.com",
  email_verified: true,
  family_name: "Correia",
  given_name: "Nelson",
  locale: "en",
  name: "Nelson Correia",
  picture: "https://lh3.googleusercontent.com/a-/AAuE7mApnYb260YC1JY7",
  sub: "940732358705212133793"
}

[nelsonic]

@SimonLab thanks for sense checking this suggestion and merging my PR #22 👍

[jasmo2]

It still have the error even with the atoms

The way are been call is like this:
ElixirAuthGoogle.get_user_profile(token)

protocol String.Chars not implemented for %{email: "em@mail.com", email_verified: true, family_name: "OKAY", given_name: "OKAY", locale: "en-GB", name: "OK OK"} of type Map

[nelsonic]

GOTO: #28 (issue for discussing this)