Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate to fly.io issue #15 #16

Merged
merged 17 commits into from
Feb 13, 2023
Merged

PR: Migrate to fly.io issue #15 #16

merged 17 commits into from
Feb 13, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Feb 9, 2023

This PR:

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@960fe1d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4e295dd differs from pull request most recent head 35cc0b8. Consider uploading reports for the commit 35cc0b8 to get more accurate results

@@           Coverage Diff            @@
##             main       #16   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?         9           
  Branches        ?         0           
========================================
  Hits            ?         9           
  Misses          ?         0           
  Partials        ?         0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic
Copy link
Member Author

nelsonic commented Feb 9, 2023

@SimonLab please take a look at this PR.
Successfully deployed to: https://elixir-google-auth-demo.fly.dev/

image

You have access: https://fly.io/dashboard/dwyl-elixir-auth-google-demo
But shouldn't need to do much with it as it "just works". ✅

This was referenced Feb 9, 2023
Closed
Closed
@nelsonic nelsonic requested a review from SimonLab February 9, 2023 21:55
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes labels Feb 9, 2023
nelsonic
nelsonic commented Feb 10, 2023
View reviewed changes
Copy link
Member Author

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😜

@nelsonic nelsonic added T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. and removed T25m Time Estimate 25 Minutes labels Feb 10, 2023
nelsonic
nelsonic commented Feb 10, 2023
View reviewed changes
README.md
@@ -268,11 +277,126 @@ they should see the following welcome message:

![welcome](https://user-images.githubusercontent.com/194400/70201692-494db880-170f-11ea-9776-0ffd1fdf5a72.png)

## Testing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs for testing. Ref: dwyl/elixir-auth-google#82

SimonLab
SimonLab approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonLab SimonLab merged commit a8249ed into main Feb 13, 2023
@SimonLab SimonLab deleted the migrate-to-fly.io-issue-#15 branch February 13, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab