Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing errorhandler to the npm request module used internally. #43

Open
gautam1168 opened this issue Aug 18, 2019 · 0 comments
Open

Comments

@gautam1168
Copy link

The npm 'request' module supports passing in a callback function that is called after the request is completed with the result or the error. There is no way to pass this callback/handler currently. This is required because making a call to an non-existent url using express-request-proxy throws an error that cannot be caught by the caller program. I have made a PR to add this: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant