Skip to content

Commit

Permalink
Update NGINX download method and improve consistency
Browse files Browse the repository at this point in the history
Replaced manual NGINX downloading with the `lastversion-action` GitHub action for better maintainability and simplicity. Corrected a typo in the README ("WordPress" instead of "Wordpress") and removed an unused Patreon funding entry in the configuration file.
  • Loading branch information
dvershinin committed Jan 3, 2025
1 parent 84ec606 commit 186d57b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
1 change: 0 additions & 1 deletion .github/FUNDING.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ ko_fi: null
liberapay: null
open_collective: null
otechie: null
patreon: getpagespeed
tidelift: null
18 changes: 8 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,14 @@ jobs:
- name: Create NGINX download directory
run: |
mkdir nginx
wget -O nginx.tar.gz https://nginx.org/download/nginx-1.26.2.tar.gz
tar -xzf nginx.tar.gz -C nginx --strip-components=1
# - name: Download ${{ matrix.nginx-branch }} NGINX
# uses: dvershinin/lastversion-action@main
# with:
# repository: 'nginx'
# action: 'unzip'
# branch: ${{ matrix.nginx-branch }}
# working_directory: ./nginx
- name: Download ${{ matrix.nginx-branch }} NGINX
uses: dvershinin/lastversion-action@main
with:
repository: 'nginx'
action: 'unzip'
branch: ${{ matrix.nginx-branch }}
working_directory: ./nginx

- name: Configure NGINX to compile with the module statically
run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ curl -IL https://www.example.com/
Another worthy thing to mention is that it makes little to no sense applying dynamic `ETag` on a page that changes on
each reload. E.g. I found I wasn't using the dynamic `ETag` with benefits, because of `<?= antispambot(get_option('admin_email')) ?>`,
in my Wordpress theme's `header.php`, since in this function:
in my WordPress theme's `header.php`, since in this function:

> the selection is random and changes each time the function is called
Expand Down

0 comments on commit 186d57b

Please sign in to comment.